[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9728: [Bug] If function adds type inference

[GitBox <gi...@apache.org>]

cambyzju commented on code in PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#discussion_r878971202


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##########
@@ -869,6 +869,11 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
                 childTypes[i] = children.get(i).type;
             }
 
+        } else if (fnName.getFunction().equalsIgnoreCase("if")) {
+            Type[] childTypes = collectChildReturnTypes();
+            Type assignmentCompatibleType = ScalarType.getAssignmentCompatibleType(childTypes[1], childTypes[2], true);
+            childTypes[1] = assignmentCompatibleType;
+            childTypes[2] = assignmentCompatibleType;
             fn = getBuiltinFunction(analyzer, fnName.getFunction(), childTypes,

Review Comment:
   After this change, FunctionSet.WINDOW_FUNNEL will not call getBuiltinFunction any more. 
   
   It seams FunctionSet.WINDOW_FUNNEL will work not correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org