You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/04/05 23:09:12 UTC
[hadoop] branch trunk updated: HDFS-14371. Improve Logging in
FSNamesystem by adding parameterized logging. Contributed by Shweta.
This is an automated email from the ASF dual-hosted git repository.
weichiu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new e9b859f HDFS-14371. Improve Logging in FSNamesystem by adding parameterized logging. Contributed by Shweta.
e9b859f is described below
commit e9b859f749103dc15fb4b4fc677f5586fceb20b3
Author: Shweta <sh...@cloudera.com>
AuthorDate: Fri Apr 5 16:08:05 2019 -0700
HDFS-14371. Improve Logging in FSNamesystem by adding parameterized logging. Contributed by Shweta.
Signed-off-by: Wei-Chiu Chuang <we...@apache.org>
---
.../hadoop/hdfs/server/namenode/FSNamesystem.java | 23 +++++++---------------
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
index ba806d2..82015b2 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
@@ -2413,10 +2413,8 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
for (CryptoProtocolVersion c : supportedVersions) {
if (c.equals(CryptoProtocolVersion.UNKNOWN)) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Ignoring unknown CryptoProtocolVersion provided by " +
- "client: " + c.getUnknownValue());
- }
+ LOG.debug("Ignoring unknown CryptoProtocolVersion provided by " +
+ "client: {}", c.getUnknownValue());
continue;
}
if (c.equals(required)) {
@@ -3693,9 +3691,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
if (deleteblock) {
// This may be a retry attempt so ignore the failure
// to locate the block.
- if (LOG.isDebugEnabled()) {
- LOG.debug("Block (=" + oldBlock + ") not found");
- }
+ LOG.debug("Block (={}) not found", oldBlock);
return;
} else {
throw new IOException("Block (=" + oldBlock + ") not found");
@@ -3729,9 +3725,8 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
if ((!iFile.isUnderConstruction() || storedBlock.isComplete()) &&
iFile.getLastBlock().isComplete()) {
if (LOG.isDebugEnabled()) {
- LOG.debug("Unexpected block (=" + oldBlock
- + ") since the file (=" + iFile.getLocalName()
- + ") is not under construction");
+ LOG.debug("Unexpected block (={}) since the file (={}) is not "
+ + "under construction", oldBlock, iFile.getLocalName());
}
return;
}
@@ -5636,9 +5631,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
}
}
cookieTab[0] = String.valueOf(skip);
- if (LOG.isDebugEnabled()) {
- LOG.debug("list corrupt file blocks returned: " + count);
- }
+ LOG.debug("list corrupt file blocks returned: {}", count);
return corruptFiles;
} finally {
readUnlock("listCorruptFileBlocks");
@@ -6370,9 +6363,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
}
}
} catch (StandbyException e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Get corrupt file blocks returned error: " + e.getMessage());
- }
+ LOG.debug("Get corrupt file blocks returned error: {}", e.getMessage());
} catch (IOException e) {
LOG.warn("Get corrupt file blocks returned error", e);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org