You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/10/10 00:12:20 UTC
Review Request 39193: Fixed leakage of fts_open.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39193/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519
Repository: mesos
Description
-------
Fixed leakage of fts_open.
Diffs
-----
src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
Diff: https://reviews.apache.org/r/39193/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 39193: Fixed leakage of fts_open.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39193/#review102141
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39192, 39193]
All tests passed.
- Mesos ReviewBot
On Oct. 9, 2015, 10:12 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39193/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 10:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed leakage of fts_open.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
>
> Diff: https://reviews.apache.org/r/39193/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 39193: Fixed leakage of fts_open.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39193/#review102315
-----------------------------------------------------------
Ship it!
src/linux/cgroups.cpp (lines 925 - 926)
<https://reviews.apache.org/r/39193/#comment159920>
The = should go on the first line, I'll fix this for you
- Ben Mahler
On Oct. 12, 2015, 8:19 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39193/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 8:19 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed leakage of fts_open.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
>
> Diff: https://reviews.apache.org/r/39193/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 39193: Fixed leakage of fts_open.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39193/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 8:19 p.m.)
Review request for mesos and Ben Mahler.
Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519
Repository: mesos
Description
-------
Fixed leakage of fts_open.
Diffs (updated)
-----
src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
Diff: https://reviews.apache.org/r/39193/diff/
Testing (updated)
-------
make check
Thanks,
Chi Zhang
Re: Review Request 39193: Fixed leakage of fts_open.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39193/#review102128
-----------------------------------------------------------
src/linux/cgroups.cpp (line 925)
<https://reviews.apache.org/r/39193/#comment159691>
Ditto here, can you preserve the intended errno for ErrnoError?
- Ben Mahler
On Oct. 9, 2015, 10:12 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39193/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 10:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed leakage of fts_open.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
>
> Diff: https://reviews.apache.org/r/39193/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>