You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2018/06/15 23:40:27 UTC

[maven-integration-testing] branch master updated: [MNG-6428] IT for MNG-5958 fails on Java 9+

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git


The following commit(s) were added to refs/heads/master by this push:
     new b7f0bca  [MNG-6428] IT for MNG-5958 fails on Java 9+
b7f0bca is described below

commit b7f0bca65ce458d70daa16d00f249cb49ba688c6
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Jun 16 01:37:21 2018 +0200

    [MNG-6428] IT for MNG-5958 fails on Java 9+
---
 .../maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java     | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
index 3ee3fe1..add814d 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
@@ -17,19 +17,19 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         throws Exception
     {
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/good" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         verifier.executeGoal( "validate" );
         verifier.verifyErrorFreeLog();
         verifier.verifyTextInLog( "CLASS_NAME=java.lang.String" );
         verifier.resetStreams();
     }
-    
+
     public void testBad()
         throws Exception
     {
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/bad" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         try
         {
@@ -37,8 +37,10 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         }
         catch ( VerificationException e )
         {
+            // TODO There is no good way to test for Java 9+ in Verifier in order to add 'java.base/'
+            // to the string.
             verifier.verifyTextInLog( "[ERROR] Internal error: java.lang.ClassCastException: "
-                + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to java.lang.String -> [Help 1]" );
+                + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to " );
         }
         verifier.resetStreams();
     }

-- 
To stop receiving notification emails like this one, please contact
michaelo@apache.org.