You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/08 00:17:18 UTC
Review Request 42040: Added Quota Operator Documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs
-----
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > Can we link this page from `home.md`?
> >
> > Overall: looks great! Only major feedback is to move the implementation details down to the bottom (or remove them), and refactor things slightly so that any user-visible behavior (e.g., failover and capacity check heuristic) are discussed outside the "implementation details" section.
That was exactly our intention to surface capacity heuristic and rescinding, see my comment below on the proposal how we can restructure this.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 226
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line226>
> >
> > Fix this link -- probably just link to roles.md. Although we don't really call the feature "implicit roles" in the user-facing docs (we just talk about whether a "role whitelist" has been configured), so maybe we can just remove this.
Though it indeed seems weird to mention random features in this user doc, I would love to mention implicit roles somewhere here. The motivation is that it's a new (read: relatively unknown) feature, which is highly related to quota. I would like to make sure an operator reading this doc is aware of the feature and can use it appropriately. The best solution would be to add a `NOTE` or a sentence and remove it in ~6 month, when implicit roles become standard. Unfortunately, we do not support remove `TODO`s in user docs : )
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 61
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line61>
> >
> > These kinds of implementation details belong at the bottom of the document, I think -- it is more important to tell the user/operator how to define quota before we worry about allocator details.
> >
> > We could also remove a lot of this information -- the specific steps we take to implement a set/remove quota request are not an important thing to document (and might change over time).
Our intention was *not* to provide implementation details, but to mention some of those, which are important and affect cluster behaviour. There are 3 things: capacity heuristic, rescinding offers, allocator logic (quota first, fair share second). I do think we should explain operators how these things work so that they don't break their clusters.
However, if the section feels like an "implementation details" section, we didn't achieve our goal. The reason we decided to briefly mention other stages is in order not to be misleading and leave an impression, that there is nothing else.
Do you think leaving only these 3 sections and adding a sentence that those are most important stages in quota processing is a good compromise?
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 21
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line21>
> >
> > Is the analogy between quota and dynamic reservation accurate/helpful? A dynamic reservation reserves _particular_ resources on a _specific_ agent, and the reservation fails if the resources are unavailable; quota just ensures that _sufficient_ resources in one or more agents are dedicated for the role. Calling quota a "cluster-wide dynamic reservation" doesn't capture this, IMO.
A dynamic reservation does not reserve a _particular_ resource. The difference between reserving on a specific agent and anywhere in the cluster is captured by "cluster-wide". You are right that a dynamic reservation fails if there are not enough resources, but same does quota due to the capacity heuristic check.
The reason we decided to add this sentence is to give operators better understanding what this new feature is about using analogy with things they are already familiar with. However, if folks think the analogy is more misleading than helpful, we can remove this sentence.
I personally prefer being slightly imprecise but give the big picture and intuition. I remember a poster in the Institute for Nuclear Research in Dubna, here is my translation: "One should explain a scientific problem to a big boss not in the precise and correct way, but in a way the big boss understands. It is a lie for good."
Original for those who reads Russian: "????????? ??????? ?????????? ??????? ???????? ????? ?? ?????????, ? ???, ??? ??? ????? ???????. ??? ???? ?? ?????."
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------
On Jan. 7, 2016, 11:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 61
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line61>
> >
> > These kinds of implementation details belong at the bottom of the document, I think -- it is more important to tell the user/operator how to define quota before we worry about allocator details.
> >
> > We could also remove a lot of this information -- the specific steps we take to implement a set/remove quota request are not an important thing to document (and might change over time).
>
> Alexander Rukletsov wrote:
> Our intention was *not* to provide implementation details, but to mention some of those, which are important and affect cluster behaviour. There are 3 things: capacity heuristic, rescinding offers, allocator logic (quota first, fair share second). I do think we should explain operators how these things work so that they don't break their clusters.
>
> However, if the section feels like an "implementation details" section, we didn't achieve our goal. The reason we decided to briefly mention other stages is in order not to be misleading and leave an impression, that there is nothing else.
>
> Do you think leaving only these 3 sections and adding a sentence that those are most important stages in quota processing is a good compromise?
>
> Neil Conway wrote:
> I think we could improve things in two ways:
>
> 1. Move the "How does it work?" section to the end of the document. Although this is useful material, it is fairly advanced; a lot of users will want to just know how to configure/examine quota.
> 2. Remove some of the implementation details. For example, the fact that we authenticate, parse, validate, and authorize a quota request is not important for the information we want to convey to operators about how quotas behave.
IMO all steps (except inform allocator, which I agree can be dropped) have potential implication for the operator as he might receive error relating to each stage or it influences the behavior of the cluster (failover & rescinding).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Neil Conway <ne...@gmail.com>.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 226
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line226>
> >
> > Fix this link -- probably just link to roles.md. Although we don't really call the feature "implicit roles" in the user-facing docs (we just talk about whether a "role whitelist" has been configured), so maybe we can just remove this.
>
> Alexander Rukletsov wrote:
> Though it indeed seems weird to mention random features in this user doc, I would love to mention implicit roles somewhere here. The motivation is that it's a new (read: relatively unknown) feature, which is highly related to quota. I would like to make sure an operator reading this doc is aware of the feature and can use it appropriately. The best solution would be to add a `NOTE` or a sentence and remove it in ~6 month, when implicit roles become standard. Unfortunately, we do not support remove `TODO`s in user docs : )
Maybe we can rephrase this to talk in terms of whether a "role whitelist" has been configured?
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 61
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line61>
> >
> > These kinds of implementation details belong at the bottom of the document, I think -- it is more important to tell the user/operator how to define quota before we worry about allocator details.
> >
> > We could also remove a lot of this information -- the specific steps we take to implement a set/remove quota request are not an important thing to document (and might change over time).
>
> Alexander Rukletsov wrote:
> Our intention was *not* to provide implementation details, but to mention some of those, which are important and affect cluster behaviour. There are 3 things: capacity heuristic, rescinding offers, allocator logic (quota first, fair share second). I do think we should explain operators how these things work so that they don't break their clusters.
>
> However, if the section feels like an "implementation details" section, we didn't achieve our goal. The reason we decided to briefly mention other stages is in order not to be misleading and leave an impression, that there is nothing else.
>
> Do you think leaving only these 3 sections and adding a sentence that those are most important stages in quota processing is a good compromise?
I think we could improve things in two ways:
1. Move the "How does it work?" section to the end of the document. Although this is useful material, it is fairly advanced; a lot of users will want to just know how to configure/examine quota.
2. Remove some of the implementation details. For example, the fact that we authenticate, parse, validate, and authorize a quota request is not important for the information we want to convey to operators about how quotas behave.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 21
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line21>
> >
> > Is the analogy between quota and dynamic reservation accurate/helpful? A dynamic reservation reserves _particular_ resources on a _specific_ agent, and the reservation fails if the resources are unavailable; quota just ensures that _sufficient_ resources in one or more agents are dedicated for the role. Calling quota a "cluster-wide dynamic reservation" doesn't capture this, IMO.
>
> Alexander Rukletsov wrote:
> A dynamic reservation does not reserve a _particular_ resource. The difference between reserving on a specific agent and anywhere in the cluster is captured by "cluster-wide". You are right that a dynamic reservation fails if there are not enough resources, but same does quota due to the capacity heuristic check.
>
> The reason we decided to add this sentence is to give operators better understanding what this new feature is about using analogy with things they are already familiar with. However, if folks think the analogy is more misleading than helpful, we can remove this sentence.
>
> I personally prefer being slightly imprecise but give the big picture and intuition. I remember a poster in the Institute for Nuclear Research in Dubna, here is my translation: "One should explain a scientific problem to a big boss not in the precise and correct way, but in a way the big boss understands. It is a lie for good."
>
> Original for those who reads Russian: "????????? ??????? ?????????? ??????? ???????? ????? ?? ?????????, ? ???, ??? ??? ????? ???????. ??? ???? ?? ?????."
We rephrased it to better connect to Quota.
> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote:
> > docs/quota.md, line 226
> > <https://reviews.apache.org/r/42040/diff/1/?file=1186512#file1186512line226>
> >
> > Fix this link -- probably just link to roles.md. Although we don't really call the feature "implicit roles" in the user-facing docs (we just talk about whether a "role whitelist" has been configured), so maybe we can just remove this.
>
> Alexander Rukletsov wrote:
> Though it indeed seems weird to mention random features in this user doc, I would love to mention implicit roles somewhere here. The motivation is that it's a new (read: relatively unknown) feature, which is highly related to quota. I would like to make sure an operator reading this doc is aware of the feature and can use it appropriately. The best solution would be to add a `NOTE` or a sentence and remove it in ~6 month, when implicit roles become standard. Unfortunately, we do not support remove `TODO`s in user docs : )
>
> Neil Conway wrote:
> Maybe we can rephrase this to talk in terms of whether a "role whitelist" has been configured?
Rephrased to ```However if the master is configured without an explicit
[role whitelist](roles.md) a set request can introduce new roles.```
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113358
-----------------------------------------------------------
Can we link this page from `home.md`?
Overall: looks great! Only major feedback is to move the implementation details down to the bottom (or remove them), and refactor things slightly so that any user-visible behavior (e.g., failover and capacity check heuristic) are discussed outside the "implementation details" section.
docs/quota.md (line 7)
<https://reviews.apache.org/r/42040/#comment173907>
This seems a confusing way to start the document. How can a single framework "hog all of the resources?" While I can see how this is possible, I think it will be hard for many readers to grasp.
I wonder if we should begin by quickly reviewing the quota-less DRF behavior, and showing how one framework can hog all the resoures. Then say how quota provides a means to avoid this.
docs/quota.md (line 21)
<https://reviews.apache.org/r/42040/#comment173906>
Is the analogy between quota and dynamic reservation accurate/helpful? A dynamic reservation reserves _particular_ resources on a _specific_ agent, and the reservation fails if the resources are unavailable; quota just ensures that _sufficient_ resources in one or more agents are dedicated for the role. Calling quota a "cluster-wide dynamic reservation" doesn't capture this, IMO.
docs/quota.md (line 26)
<https://reviews.apache.org/r/42040/#comment173908>
"that manages a Mesos cluster."
docs/quota.md (line 28)
<https://reviews.apache.org/r/42040/#comment173909>
'In computer science, a "quota" usually..."
docs/quota.md (line 44)
<https://reviews.apache.org/r/42040/#comment173910>
Period after "100 CPUs", not comma.
docs/quota.md (line 45)
<https://reviews.apache.org/r/42040/#comment173911>
", while fB is greedy..."
docs/quota.md (line 46)
<https://reviews.apache.org/r/42040/#comment173912>
"fair share"
"hogging the remaining 90 CPUs"
docs/quota.md (line 47)
<https://reviews.apache.org/r/42040/#comment173914>
"the additional"
docs/quota.md (line 52)
<https://reviews.apache.org/r/42040/#comment173916>
I think we want em-dash ("---") here, without spaces on either side. i.e., "resources---100 CPUs."
docs/quota.md (line 53)
<https://reviews.apache.org/r/42040/#comment173917>
I'd put a comma after "joins the cluster".
I'd say "it will not receive its fair share of the cluster resources (50 CPUs) until ..."
docs/quota.md (line 56)
<https://reviews.apache.org/r/42040/#comment173918>
Comma after "Scenario 2".
docs/quota.md (line 57)
<https://reviews.apache.org/r/42040/#comment173919>
In Scenario 2, it is fB that uses all the resources, not fA.
Remove "the" from "after the fA"
docs/quota.md (line 61)
<https://reviews.apache.org/r/42040/#comment173920>
These kinds of implementation details belong at the bottom of the document, I think -- it is more important to tell the user/operator how to define quota before we worry about allocator details.
We could also remove a lot of this information -- the specific steps we take to implement a set/remove quota request are not an important thing to document (and might change over time).
docs/quota.md (line 76)
<https://reviews.apache.org/r/42040/#comment173923>
Why capitalize Quota here?
Typically we want "e.g.," not "e.g."
docs/quota.md (line 82)
<https://reviews.apache.org/r/42040/#comment173924>
You haven't told the reader what "the master endpoint" is.
docs/quota.md (line 106)
<https://reviews.apache.org/r/42040/#comment173925>
Not sure this belongs in the implementation details section, because it influences user-facing behavior.
docs/quota.md (line 133)
<https://reviews.apache.org/r/42040/#comment173926>
I found this sentence confusing.
docs/quota.md (line 180)
<https://reviews.apache.org/r/42040/#comment173927>
"enables operators to configure quotas."
docs/quota.md (line 190)
<https://reviews.apache.org/r/42040/#comment173928>
"set a new one."
docs/quota.md (line 192)
<https://reviews.apache.org/r/42040/#comment173929>
"See the [...](auth...) for details."
docs/quota.md (line 198)
<https://reviews.apache.org/r/42040/#comment173930>
"an HTTP", I'd think.
docs/quota.md (line 206)
<https://reviews.apache.org/r/42040/#comment173931>
"12 CPUs", for consistency with the preceding text in the doc, I'd think.
docs/quota.md (line 226)
<https://reviews.apache.org/r/42040/#comment173933>
Fix this link -- probably just link to roles.md. Although we don't really call the feature "implicit roles" in the user-facing docs (we just talk about whether a "role whitelist" has been configured), so maybe we can just remove this.
docs/quota.md (line 240)
<https://reviews.apache.org/r/42040/#comment173935>
"will receive"
"HTTP response codes"
docs/quota.md (line 253)
<https://reviews.apache.org/r/42040/#comment173937>
"an HTTP"
docs/quota.md (line 254)
<https://reviews.apache.org/r/42040/#comment173938>
I'd just say "endpoint", we said "HTTP" in this sentence already.
docs/quota.md (line 259)
<https://reviews.apache.org/r/42040/#comment173940>
"will receive"
"HTTP response codes"
docs/quota.md (line 270)
<https://reviews.apache.org/r/42040/#comment173936>
"query the configured quotas"
docs/quota.md (line 299)
<https://reviews.apache.org/r/42040/#comment173939>
"will receive"
"HTTP response codes"
docs/quota.md (line 306)
<https://reviews.apache.org/r/42040/#comment173941>
"does not allow specifying" ("does not allow to specify" is ungrammatical). Similarly below.
- Neil Conway
On Jan. 7, 2016, 11:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113402
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42040]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 7, 2016, 11:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:17 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113496
-----------------------------------------------------------
docs/home.md (line 42)
<https://reviews.apache.org/r/42040/#comment174237>
Typo
docs/quota.md (line 109)
<https://reviews.apache.org/r/42040/#comment174238>
"quota of 1000 CPUs"
docs/quota.md (line 117)
<https://reviews.apache.org/r/42040/#comment174239>
I think "non-static cluster resources" is not quite accurate here. We care about whether the total quota exceeds the "total non-statically-reserved cluster resources", or something like that (we need to say "static reservation", not "static cluster resource").
docs/quota.md (line 124)
<https://reviews.apache.org/r/42040/#comment174240>
"configured quotas"
docs/quota.md (line 126)
<https://reviews.apache.org/r/42040/#comment174241>
"The force flag".
Period after "this check". I'd also rephrase slightly: "For example, this flag can be useful when the operator would like to configure a quota that exceeds the current cluster capacity, but they know that additional cluster resources will be added shortly."
docs/quota.md (line 170)
<https://reviews.apache.org/r/42040/#comment174242>
"are detected"
docs/quota.md (line 175)
<https://reviews.apache.org/r/42040/#comment174243>
"reregister"
docs/quota.md (line 176)
<https://reviews.apache.org/r/42040/#comment174244>
add "or" at the end of the first bullet point
- Neil Conway
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 306-310
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line306>
> >
> > 1) what about adding "update Quota" here and remove it from L189
> > 2) no Quota Limit but only guarantee
> >
> > Another point is that shall we put quota design document link here to naviagte someone there if they want to get some design detail for Quota?
>
> Joerg Schad wrote:
> 1) Added it here (brief) with a link to L189.
> 2) As we do not mention Quota Limits above, I would also not mention it here (see our current definition of quota).
>
> Guangya Liu wrote:
> OK
Let's not mention the design doc in user docs. The proper place for a design doc is apache confluence. Updating, cleaning up, and moving the design doc to Confluence is on my list. I would suggest we do not block this review because of that.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 306-310
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line306>
> >
> > 1) what about adding "update Quota" here and remove it from L189
> > 2) no Quota Limit but only guarantee
> >
> > Another point is that shall we put quota design document link here to naviagte someone there if they want to get some design detail for Quota?
1) Added it here (brief) with a link to L189.
2) As we do not mention Quota Limits above, I would also not mention it here (see our current definition of quota).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 33-34
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line33>
> >
> > But we did have plan to introduce maximal limit in MESOS-3858 , can we calarify here?
>
> Joerg Schad wrote:
> We discussed that part, but agreed that this documentation is for operators (how to use the current feature) and supposed to reflect the current state.
>
> Guangya Liu wrote:
> Fair enough.
Can I drop the issue? If not please reopen.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 306-310
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line306>
> >
> > 1) what about adding "update Quota" here and remove it from L189
> > 2) no Quota Limit but only guarantee
> >
> > Another point is that shall we put quota design document link here to naviagte someone there if they want to get some design detail for Quota?
>
> Joerg Schad wrote:
> 1) Added it here (brief) with a link to L189.
> 2) As we do not mention Quota Limits above, I would also not mention it here (see our current definition of quota).
OK
> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 175
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line175>
> >
> > Do we need to mention that the 80% is not configurable now?
>
> Joerg Schad wrote:
> I would just add a note once it is configurable.
OK
> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 70
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line70>
> >
> > s/to even/even ?
>
> Joerg Schad wrote:
> changed it to 'event to ignore'
I think you meant "even to ignore".
> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 33-34
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line33>
> >
> > But we did have plan to introduce maximal limit in MESOS-3858 , can we calarify here?
>
> Joerg Schad wrote:
> We discussed that part, but agreed that this documentation is for operators (how to use the current feature) and supposed to reflect the current state.
Fair enough.
> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 20
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line20>
> >
> > s/a cluster-wide dynamic reservation/a cluster-wide dynamic reservation without resource preemption
> >
> > MESOS-1607 is introducing oversubscription for reservations, so the reservation resources can be preempted based on workload. Can we clarify it a bit here as above?
>
> Joerg Schad wrote:
> IMO 'without resource preemption' is adding more confusion than details at this point . Can you maybe explain the motivation behing adding this here?
>
> With Mesos-1607 I would not reference open Jiras in the operator guide which is concerned with how to use the current feature.
OK, I see, just want to clarify that Quota do not support resource preemption now, as dynamic reservation is going to support resource preemption in MESOS-1607, "Quota can be viewed as a cluster-wide dynamic reservation" makes me think that the Quota also supports resource preemption like dynamic reservations.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On 一月 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 70
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line70>
> >
> > s/to even/even ?
>
> Joerg Schad wrote:
> changed it to 'event to ignore'
>
> Guangya Liu wrote:
> I think you meant "even to ignore".
yes, that is also what I put in the doc :-).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, lines 33-34
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line33>
> >
> > But we did have plan to introduce maximal limit in MESOS-3858 , can we calarify here?
We discussed that part, but agreed that this documentation is for operators (how to use the current feature) and supposed to reflect the current state.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 20
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line20>
> >
> > s/a cluster-wide dynamic reservation/a cluster-wide dynamic reservation without resource preemption
> >
> > MESOS-1607 is introducing oversubscription for reservations, so the reservation resources can be preempted based on workload. Can we clarify it a bit here as above?
IMO 'without resource preemption' is adding more confusion than details at this point . Can you maybe explain the motivation behing adding this here?
With Mesos-1607 I would not reference open Jiras in the operator guide which is concerned with how to use the current feature.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 70
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line70>
> >
> > s/to even/even ?
changed it to 'event to ignore'
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 175
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line175>
> >
> > Do we need to mention that the 80% is not configurable now?
I would just add a note once it is configurable.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 177
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line177>
> >
> > also not configurable now
Same as above.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote:
> > docs/quota.md, line 175
> > <https://reviews.apache.org/r/42040/diff/2/?file=1187349#file1187349line175>
> >
> > Do we need to mention that the 80% is not configurable now?
>
> Joerg Schad wrote:
> I would just add a note once it is configurable.
>
> Guangya Liu wrote:
> OK
I assume this is ok to drop then? Otherwise please reopen (also below).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113601
-----------------------------------------------------------
docs/quota.md (line 20)
<https://reviews.apache.org/r/42040/#comment174355>
s/a cluster-wide dynamic reservation/a cluster-wide dynamic reservation without resource preemption
MESOS-1607 is introducing oversubscription for reservations, so the reservation resources can be preempted based on workload. Can we clarify it a bit here as above?
docs/quota.md (lines 33 - 34)
<https://reviews.apache.org/r/42040/#comment174356>
But we did have plan to introduce maximal limit in MESOS-3858 , can we calarify here?
docs/quota.md (lines 63 - 64)
<https://reviews.apache.org/r/42040/#comment174358>
s/quota set request/quota set request issued by operator
docs/quota.md (line 70)
<https://reviews.apache.org/r/42040/#comment174359>
s/to even/even ?
docs/quota.md (line 76)
<https://reviews.apache.org/r/42040/#comment174360>
s/scalar resources/unreserved and non-revocable scalar resourcess
docs/quota.md (line 153)
<https://reviews.apache.org/r/42040/#comment174361>
s/quota set until/quota set?
docs/quota.md (line 175)
<https://reviews.apache.org/r/42040/#comment174362>
Do we need to mention that the 80% is not configurable now?
docs/quota.md (line 177)
<https://reviews.apache.org/r/42040/#comment174363>
also not configurable now
docs/quota.md (line 227)
<https://reviews.apache.org/r/42040/#comment174364>
Add a link to implicit role?
docs/quota.md (lines 306 - 310)
<https://reviews.apache.org/r/42040/#comment174365>
1) what about adding "update Quota" here and remove it from L189
2) no Quota Limit but only guarantee
Another point is that shall we put quota design document link here to naviagte someone there if they want to get some design detail for Quota?
- Guangya Liu
On 一月 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated 一月 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113455
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42040]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 8, 2016, 10:26 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:26 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113815
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Jan. 11, 2016, 6:51 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Jan. 12, 2016, 3 a.m., Alexander Rukletsov wrote:
> > docs/quota.md, line 313
> > <https://reviews.apache.org/r/42040/diff/3/?file=1192262#file1192262line313>
> >
> > Is there a trailing blank line?
In my patch yes. Not sure what rb does...
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113916
-----------------------------------------------------------
On Jan. 11, 2016, 6:51 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113916
-----------------------------------------------------------
Ship it!
docs/quota.md (line 61)
<https://reviews.apache.org/r/42040/#comment174694>
Unnecessary blank line.
docs/quota.md (line 73)
<https://reviews.apache.org/r/42040/#comment174700>
I think you can kill "currently" here, you have already said that in the previous sentence.
docs/quota.md (line 83)
<https://reviews.apache.org/r/42040/#comment174702>
Kill "HTTP" here.
docs/quota.md (line 116)
<https://reviews.apache.org/r/42040/#comment174695>
Unnecessary blank line.
docs/quota.md (line 122)
<https://reviews.apache.org/r/42040/#comment174696>
Unnecessary blank line.
docs/quota.md (line 124)
<https://reviews.apache.org/r/42040/#comment174703>
We refer to this guy as an operator. Please correct all instances.
docs/quota.md (line 155)
<https://reviews.apache.org/r/42040/#comment174704>
Kill "HTTP" here.
docs/quota.md (line 221)
<https://reviews.apache.org/r/42040/#comment174699>
You already have an anchor named "removeRequest". Please correct the naming scheme and update all references accordingly.
docs/quota.md (line 259)
<https://reviews.apache.org/r/42040/#comment174697>
Unnecessary blank line.
docs/quota.md (line 261)
<https://reviews.apache.org/r/42040/#comment174707>
s/remaing/remaining
docs/quota.md (line 298)
<https://reviews.apache.org/r/42040/#comment174706>
Please use em-dashes ("---") without spaces instead.
docs/quota.md (line 313)
<https://reviews.apache.org/r/42040/#comment174698>
Is there a trailing blank line?
- Alexander Rukletsov
On Jan. 11, 2016, 6:51 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113982
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42040]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 12, 2016, 8:54 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 8:54 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review114892
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 13, 2016, 2:43 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 2:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
> Used docker website renderer to check output and links
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 2:43 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs
-----
docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing (updated)
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Used docker website renderer to check output and links
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 1:53 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Changes
-------
Changed anchors as they were incorrectly rendered by website markdown parser.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs (updated)
-----
docs/home.md 344c5617dfb003453fa17974500d44a8f766cb16
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 8:54 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Changes
-------
Added missed space.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs (updated)
-----
docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 8:42 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Changes
-------
Adressed Alex's comments.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs (updated)
-----
docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/#review113873
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42040]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 11, 2016, 6:51 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42040/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 6:51 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3877
> https://issues.apache.org/jira/browse/MESOS-3877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Quota Operator Documentation.
>
>
> Diffs
> -----
>
> docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
> docs/quota.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42040/diff/
>
>
> Testing
> -------
>
> Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 6:51 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Changes
-------
Addressed comments.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs (updated)
-----
docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad
Re: Review Request 42040: Added Quota Operator Documentation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42040/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 10:26 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoortere, and Neil Conway.
Changes
-------
Adressed (parts of) Neil's comments.
Bugs: MESOS-3877
https://issues.apache.org/jira/browse/MESOS-3877
Repository: mesos
Description
-------
Added Quota Operator Documentation.
Diffs (updated)
-----
docs/home.md 6f0f4b9cb9d0da1f9960ebe7f36ce186c1317535
docs/quota.md PRE-CREATION
Diff: https://reviews.apache.org/r/42040/diff/
Testing
-------
Rendered version: https://gist.github.com/joerg84/a2c32e25d91e33045b56
Thanks,
Joerg Schad