You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/30 06:18:27 UTC

[GitHub] mistercrunch commented on issue #5091: Add required flask-appbuilder to setup

mistercrunch commented on issue #5091: Add required flask-appbuilder to setup
URL: https://github.com/apache/incubator-superset/pull/5091#issuecomment-393043208
 
 
   Given the current approach,  I think we should `>=1.10.0` and pin in `requirements.txt`, though I'm not very big on this new approach as it's brittle. Any backward compatible change to a lib is pretty much guaranteed to break our vanilla `pip install superset` .
   
   The downside of pinning is potentially missing out on bug fixes and security updates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org