You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/13 18:22:06 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #5446: OVS/GRE: bug fixes

weizhouapache opened a new pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446


   ### Description
   
   This PR fixes some issues with OVS/GRE
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921819985


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-923751966


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926931098


   <b>Trillian test result (tid-2198)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47132 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2198-kvm-centos7.zip
   Smoke tests completed. 87 look OK, 3 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 406.95 | test_internal_lb.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 143.34 | test_kubernetes_clusters.py
   test_02_VPC_default_routes | `Failure` | 610.40 | test_vpc_router_nics.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918460383


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930205185


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918494318


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-929020091


   > @sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?
   
   @sureshanaparti @DaanHoogland @nvazquez 
   I think nobody is using this setting now (advanced zone with GRE isolation) as the feature was broken in some previous versions.
   
   My opinion is
   (1) if anyone want to test it, it is fine. ping me if you need help.
   (2) if nobody have chance testing it, I think we can merge it if we make sure it does not break existing functionalities (by code review, smoke test, manual test, etc).
   
   I have tested the feature manually, 
   the new smoke test (test/integration/smoke/test_privategw_acl_ovs_gre.py) passed on kvm and xenserver. component test test_vpc_distributed_routing_offering.py passed on xenserver, but not on kvm as the feature is never implemented on kvm.
   
   if someone find bugs in their testing, we can fix them in next minor releases (4.16 will be LTS as far as I know)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926353317


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926754552


   <b>Trillian test result (tid-2195)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38095 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2195-xenserver-71.zip
   Smoke tests completed. 90 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930357899






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930401665


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-928092943


   <b>Trillian test result (tid-2212)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34079 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2212-kvm-centos7.zip
   Smoke tests completed. 90 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930205185


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930355855


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930402160


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925232041


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925965110


   <b>Trillian test result (tid-2158)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 114443 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2158-kvm-centos7.zip
   Smoke tests completed. 61 look OK, 29 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_list_clusters_metrics | `Error` | 1512.08 | test_metrics_api.py
   test_list_vms_metrics | `Error` | 0.16 | test_metrics_api.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   test_delete_account | `Error` | 1511.94 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 1.13 | test_network.py
   test_deploy_vm_l2network | `Error` | 1.15 | test_network.py
   test_l2network_restart | `Error` | 2.35 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 3.54 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 1.14 | test_network.py
   test_reboot_router | `Failure` | 0.05 | test_network.py
   test_releaseIP | `Error` | 0.47 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 0.52 | test_network.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
   ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
   ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
   ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.34 | test_domain_service_offerings.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.48 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.44 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.41 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.44 | test_iso.py
   test_01_create_iso | `Failure` | 1512.30 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3023.77 | test_iso.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_nic_secondaryip_add_remove | `Error` | 1513.10 | test_multipleips_per_nic.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 1802.12 | test_kubernetes_supported_versions.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_06_download_detached_volume | `Error` | 300.08 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 249.95 | test_volumes.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-927600090


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1401


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-929020091


   > @sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?
   
   @sureshanaparti @DaanHoogland @nvazquez 
   I think nobody is using this setting now (advanced zone with GRE isolation) as the feature was broken in some previous versions.
   
   My opinion is
   (1) if anyone want to test it, it is fine. ping me if you need help.
   (2) if nobody have chance testing it, I think we can merge it if we make sure it does not break existing functionalities (by code review, smoke test, manual test, etc).
   
   I have tested the feature manually, 
   the new smoke test (test/integration/smoke/test_privategw_acl_ovs_gre.py) passed on kvm and xenserver. component test test_vpc_distributed_routing_offering.py passed on xenserver, but not on kvm as the feature is never implemented on kvm.
   
   if someone find bugs in their testing, we can fix them in next minor releases (4.16 will be LTS as far as I know)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] svenvogel commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-920712205


   @weizhouapache only for interest because we are using OVS/VLAN at the moment with KVM. What are the fixes in detail? 😄 thanks and cheers
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925006349


   @rhtyd @weizhouapache I don't think this is a blocker as it has been broken for many releases, however, it would be great to have it on 4.16.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924691285


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-923752554


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924522242


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925296542


   Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921802158


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-928993827


   @sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926329512


   <b>Trillian Build Failed (tid-2188)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925965110


   <b>Trillian test result (tid-2158)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 114443 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2158-kvm-centos7.zip
   Smoke tests completed. 61 look OK, 29 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_list_clusters_metrics | `Error` | 1512.08 | test_metrics_api.py
   test_list_vms_metrics | `Error` | 0.16 | test_metrics_api.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   test_delete_account | `Error` | 1511.94 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 1.13 | test_network.py
   test_deploy_vm_l2network | `Error` | 1.15 | test_network.py
   test_l2network_restart | `Error` | 2.35 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 3.54 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 1.14 | test_network.py
   test_reboot_router | `Failure` | 0.05 | test_network.py
   test_releaseIP | `Error` | 0.47 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 0.52 | test_network.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
   ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
   ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
   ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.34 | test_domain_service_offerings.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.48 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.44 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.41 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.44 | test_iso.py
   test_01_create_iso | `Failure` | 1512.30 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3023.77 | test_iso.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_nic_secondaryip_add_remove | `Error` | 1513.10 | test_multipleips_per_nic.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 1802.12 | test_kubernetes_supported_versions.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_06_download_detached_volume | `Error` | 300.08 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 249.95 | test_volumes.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924522450


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930781581


   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926329397


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925547601


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-923716377


   @weizhouapache is this critical for 4.16, and is this ready for review - how are we testing it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925965110


   <b>Trillian test result (tid-2158)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 114443 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2158-kvm-centos7.zip
   Smoke tests completed. 61 look OK, 29 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_list_clusters_metrics | `Error` | 1512.08 | test_metrics_api.py
   test_list_vms_metrics | `Error` | 0.16 | test_metrics_api.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   test_delete_account | `Error` | 1511.94 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 1.13 | test_network.py
   test_deploy_vm_l2network | `Error` | 1.15 | test_network.py
   test_l2network_restart | `Error` | 2.35 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 3.54 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 1.14 | test_network.py
   test_reboot_router | `Failure` | 0.05 | test_network.py
   test_releaseIP | `Error` | 0.47 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 0.52 | test_network.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
   ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
   ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
   ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.34 | test_domain_service_offerings.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.48 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.44 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.41 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.44 | test_iso.py
   test_01_create_iso | `Failure` | 1512.30 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3023.77 | test_iso.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_nic_secondaryip_add_remove | `Error` | 1513.10 | test_multipleips_per_nic.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 1802.12 | test_kubernetes_supported_versions.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_06_download_detached_volume | `Error` | 300.08 | test_volumes.py
   ContextSuite context=TestVolumes>:teardown | `Error` | 249.95 | test_volumes.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-928092943


   <b>Trillian test result (tid-2212)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34079 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2212-kvm-centos7.zip
   Smoke tests completed. 90 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-931377304


   <b>Trillian test result (tid-2251)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33248 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2251-kvm-centos7.zip
   Smoke tests completed. 91 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921869493


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930781786


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918853825


   @blueorangutan test centos7 xenserver-71 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918500101


   @blueorangutan test centos7 xenserver-71 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-919516615


   <b>Trillian test result (tid-2031)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50918 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2031-xenserver-71.zip
   Smoke tests completed. 88 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925547394


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925013197


   > @rhtyd @weizhouapache I don't think this is a blocker as it has been broken for many releases, however, it would be great to have it on 4.16.0
   
   agree with @nvazquez 
   We can support it again since 4.16.0.0
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925174066


   <b>Trillian test result (tid-2157)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35390 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2157-xenserver-71.zip
   Smoke tests completed. 89 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_nic | `Error` | 189.43 | test_nic.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926052834


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-927576641


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925738421


   @blueorangutan test centos7 xenserver-71
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925233071


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925575663


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926353518


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926051924


   @blueorangutan test centos7 xenserver-71
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-923758203


   > @weizhouapache is this critical for 4.16, and is this ready for review - how are we testing it?
   
   @rhtyd it is ready for review.
   if we want to support OVS/GRE in 4.16.0.0 and future versions, this is critical (even blocker as the feature is totally broken on kvm, and not working well on xenserver).
   
   To test this PR, we need to create a zone with isolation method 'GRE' instead of default 'VLAN'.
   
   (for existing zone, there is no api to update the isolation method. we can change it via DB and cmk, for example
   MySQL> update physical_network_isolation_methods set isolation_method ='GRE' where id=2 and physical_network_id=201;
   cmk> add networkserviceprovider physicalnetworkid=bbb96664-cc84-4a66-af66-fd79b8fdf59a name=Ovs
   cmk> update networkserviceprovider state=Enabled id=7b806b85-bcfb-4876-8da1-1644dc229a06
   )
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924532065


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926053234


   <b>Trillian Build Failed (tid-2185)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-927609747


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-927610122


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918458896


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921801786






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-922163032


   <b>Trillian test result (tid-2114)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38606 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2114-kvm-centos7.zip
   Smoke tests completed. 89 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 75.02 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924689983


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#discussion_r714026344



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
##########
@@ -19,6 +19,7 @@
 
 package com.cloud.hypervisor.kvm.resource.wrapper;
 
+import com.google.common.base.Strings;

Review comment:
       Recently we finished a voting defining `commons.lang3` as the default string lib ([VOTE thread](https://lists.apache.org/thread.html/r806cd10b3de645c150e5e0e3d845c5a380a700197143f57f0834d758%40%3Cdev.cloudstack.apache.org%3E) & [RESULT thread](https://lists.apache.org/thread.html/r5898f717d506a0e160b9dc766b65769e2fe2f07f9cba70825843e272%40%3Cdev.cloudstack.apache.org%3E)). The code and the docs will be changed soon, could you already use `commons.lang3` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#discussion_r714059441



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
##########
@@ -19,6 +19,7 @@
 
 package com.cloud.hypervisor.kvm.resource.wrapper;
 
+import com.google.common.base.Strings;

Review comment:
       @GutoVeronezi done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926430669


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925738510


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926430857


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-926329125


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-927576977


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-928993827


   @sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#discussion_r714121551



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
##########
@@ -19,6 +19,7 @@
 
 package com.cloud.hypervisor.kvm.resource.wrapper;
 
+import com.google.common.base.Strings;

Review comment:
       @weizhouapache thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918855003


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921868652


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924688848


   @blueorangutan test centos7 xenserver-71
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925740453


   <b>Trillian Build Failed (tid-2183)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-925738820


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930355855


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918501052


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-921869474


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-930357899


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5446:
URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-924689752


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org