You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/03 17:29:42 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #2969: Fix up H7 lse help text
davids5 opened a new pull request #2969:
URL: https://github.com/apache/incubator-nuttx/pull/2969
## Summary
See https://github.com/apache/incubator-nuttx/pull/2943#issuecomment-789754798 as reported by @juniskane
## Impact
The values selected for static have to be qualified by the version silicon. So what is right on Ver V silicon will be wrong on Ver Y.
The change here to the text always provides ordinal values that select low to high. the driver will used the correct value for the silicon at run time.
0 = Low drive capability (default)
1 = Medium low drive capability
2 = Medium high drive capability
3 = High drive capability
## Testing
Build testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] juniskane commented on pull request #2969: Fix up STM32H7 lse help text
Posted by GitBox <gi...@apache.org>.
juniskane commented on pull request #2969:
URL: https://github.com/apache/incubator-nuttx/pull/2969#issuecomment-790385583
I agree with your reasoning David. Commit looks ok. Best to use monotonically rising ordinal values for H7 here, as it is the ST's silicon designer who introduced this breaking change and confusion in first place. For F7 to my knowledge all products and Revs of silicon are the same regarding these bits (swapped medium low and high settings).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2969: Fix up STM32H7 lse help text
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2969:
URL: https://github.com/apache/incubator-nuttx/pull/2969#issuecomment-790532720
> For F7 to my knowledge all products and Revs of silicon are the same regarding these bits (swapped medium low and high settings).
Thank you @juniskane!
From reviewing all the recent STM32F7 eratta that was my conclusion as well. If they just left it as is on the H7.....
Just as a heads up: I misspoke "The value can not be changed with the OCS running on the F7." It is the H7, that the update can not happen after running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2969: Fix up STM32H7 lse help text
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2969:
URL: https://github.com/apache/incubator-nuttx/pull/2969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org