You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/21 17:14:28 UTC

[GitHub] [incubator-yunikorn-core] steinsgateted commented on a change in pull request #385: [YUNIKORN-998] expose gang related info in application REST info

steinsgateted commented on a change in pull request #385:
URL: https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r831350399



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator func() NodeIterator,
 				alloc.Result = Replaced
 				// mark placeholder as released
 				ph.released = true
+				// store number of palceHolders that have been replaced so far
+				if sa.placeholderData != nil {
+					sa.placeholderData[ph.taskGroupName].Replaced++
+				}

Review comment:
       Thanks, move this code to the end of ReplaceAllocation().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org