You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (JIRA)" <ji...@apache.org> on 2013/01/15 19:56:13 UTC
[jira] [Comment Edited] (KAFKA-671) DelayedProduce requests should
not hold full producer request data
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554142#comment-13554142 ]
Neha Narkhede edited comment on KAFKA-671 at 1/15/13 6:55 PM:
--------------------------------------------------------------
Overall, the changes look good. Minor suggestions -
1. KafkaApis
1.1 Can we rename messageSizeInBytes to messageSetSize ?
1.2 Similarly rename messageSizes to messageSetSize
2. ProducerRequest
I'm guessing the resetData() API is added with the goal of helping with garbage collection ? I think this might not be required since once the produce request is handled, whether or not it entered the purgatory, it will be eligible for garbage collection
was (Author: nehanarkhede):
Overall, the changes look good. Minor suggestions -
1. KafkaApis
1.1 Can we rename messageSizeInBytes to messageSetSize ?
1.2 Similarly rename messageSizes to messageSetSize
2. ProducerRequest
I'm guessing the resetData() API is added with the goal of helping with garbage collection ? I think this might not be request since once the produce request is handled, whether or not it entered the purgatory, it will be eligible for garbage collection
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
> Key: KAFKA-671
> URL: https://issues.apache.org/jira/browse/KAFKA-671
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Sriram Subramanian
> Priority: Blocker
> Fix For: 0.8.1
>
> Attachments: outOfMemFix-v1.patch
>
>
> Per summary, this leads to unnecessary memory usage.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira