You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2016/06/23 20:20:29 UTC
svn commit: r1750013 - in /httpcomponents/httpasyncclient/branches/4.1.x:
httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/
httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/
httpasyncclient/src/main/java/org/ap...
Author: ggregory
Date: Thu Jun 23 20:20:29 2016
New Revision: 1750013
URL: http://svn.apache.org/viewvc?rev=1750013&view=rev
Log:
Add final modifier to local variables.
Modified:
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java
httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java Thu Jun 23 20:20:29 2016
@@ -94,9 +94,9 @@ class AsynchronousAsyncValidationRequest
future.get();
} catch (final ProtocolException pe) {
this.log.error("ProtocolException thrown during asynchronous revalidation", pe);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
this.log.error("Exception thrown during asynchronous revalidation", e.getCause());
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
Thread.currentThread().interrupt();
} finally {
this.parent.markComplete(this.identifier);
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java Thu Jun 23 20:20:29 2016
@@ -100,21 +100,21 @@ public class CachingHttpAsyncClientExecC
try {
final Future<HttpResponse> future = client.execute(route.getTargetHost(), request, context, null);
return Proxies.enhanceResponse(future.get());
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
Thread.currentThread().interrupt();
return null;
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
try {
throw e.getCause();
- } catch (IOException ex) {
+ } catch (final IOException ex) {
throw ex;
- } catch (HttpException ex) {
+ } catch (final HttpException ex) {
throw ex;
- } catch (RuntimeException ex) {
+ } catch (final RuntimeException ex) {
throw ex;
- } catch (Error ex) {
+ } catch (final Error ex) {
throw ex;
- } catch (Throwable ex) {
+ } catch (final Throwable ex) {
throw new UndeclaredThrowableException(ex);
}
}
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java Thu Jun 23 20:20:29 2016
@@ -111,9 +111,9 @@ public class ClientExecChainAsyncClient
HttpRequestWrapper.wrap(request),
HttpClientContext.adapt(context), null);
future.completed(result);
- } catch (IOException e) {
+ } catch (final IOException e) {
future.failed(e);
- } catch (HttpException e) {
+ } catch (final HttpException e) {
future.failed(e);
}
return future;
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java Thu Jun 23 20:20:29 2016
@@ -97,7 +97,7 @@ abstract class CloseableHttpAsyncClientB
if (this.reactorThread != null) {
try {
this.connmgr.shutdown();
- } catch (IOException ex) {
+ } catch (final IOException ex) {
this.log.error("I/O error shutting down connection manager", ex);
}
try {
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java Thu Jun 23 20:20:29 2016
@@ -113,7 +113,7 @@ class PipeliningClientExchangeHandlerImp
if (requestProducer != null) {
try {
requestProducer.close();
- } catch (IOException ex) {
+ } catch (final IOException ex) {
this.log.debug("I/O error closing request producer", ex);
}
}
@@ -123,7 +123,7 @@ class PipeliningClientExchangeHandlerImp
if (responseConsumer != null) {
try {
responseConsumer.close();
- } catch (IOException ex) {
+ } catch (final IOException ex) {
this.log.debug("I/O error closing response consumer", ex);
}
}
@@ -236,7 +236,7 @@ class PipeliningClientExchangeHandlerImp
requestProducer.requestCompleted(this.localContext);
try {
requestProducer.close();
- } catch (IOException ioex) {
+ } catch (final IOException ioex) {
this.log.debug(ioex.getMessage(), ioex);
}
}
@@ -293,7 +293,7 @@ class PipeliningClientExchangeHandlerImp
final Exception ex = responseConsumer.getException();
try {
responseConsumer.close();
- } catch (IOException ioex) {
+ } catch (final IOException ioex) {
this.log.debug(ioex.getMessage(), ioex);
}
if (result != null) {
Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java?rev=1750013&r1=1750012&r2=1750013&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java (original)
+++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java Thu Jun 23 20:20:29 2016
@@ -305,7 +305,7 @@ public class TestHttpAsyncPrematureTermi
try {
future.get();
Assert.fail();
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
final Throwable cause = e.getCause();
Assert.assertTrue("Unexpected cause: " + cause, cause instanceof IOException);
}