[jira] [Commented] (NIFI-5289) NoClassDefFoundError for org.junit.Assert When Using nifi-mock

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507479#comment-16507479 ] 

ASF GitHub Bot commented on NIFI-5289:
--------------------------------------

GitHub user MartinPayne opened a pull request:

    https://github.com/apache/nifi/pull/2780

    NIFI-5289 - Changed nifi-mock junit Dependency to Compile Scope

    Resolves NoClassDefFoundError for org.junit.Assert when using nifi-mock.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MartinPayne/nifi upstream/pr/mock-junit-dependency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2780
    
----
commit 9e43ef9a188f5afc717cb505a33b464ddaf43755
Author: Martin Payne <de...@...>
Date:   2018-06-10T18:48:57Z

    Changed nifi-mock junit Dependency to Compile Scope
    
    Resolves NoClassDefFoundError for org.junit.Assert when using nifi-mock.

----


> NoClassDefFoundError for org.junit.Assert When Using nifi-mock
> --------------------------------------------------------------
>
>                 Key: NIFI-5289
>                 URL: https://issues.apache.org/jira/browse/NIFI-5289
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.6.0
>            Reporter: Martin Payne
>            Priority: Minor
>
> When using the NiFi Mock framework but not using JUnit 4, tests fail with a NoClassDefFoundError for org.junit.Assert. This is because nifi-mock sets the scope of junit to "provided", which means it's not pulled into consuming projects as a transitive dependency. It should be set to "compile" so that users don't have to set an explicit JUnit dependency in their projects.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)