You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/09 11:34:31 UTC

[GitHub] [cloudstack-primate] DaanHoogland commented on a change in pull request #853: addldapaccount: Fix defensive check

DaanHoogland commented on a change in pull request #853:
URL: https://github.com/apache/cloudstack-primate/pull/853#discussion_r519741714



##########
File path: src/views/iam/AddLdapAccount.vue
##########
@@ -283,7 +283,7 @@ export default {
       params.domainid = store.getters.userInfo.domainid
       if (domain) {
         const result = this.listDomains.filter(item => item.name === domain)
-        if (result) {
+        if (result.length > 0) {

Review comment:
       how about result == None?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org