[GitHub] maver1ck commented on a change in pull request #4428: Proper error handling in Hive Queries

[GitBox <gi...@apache.org>]

maver1ck commented on a change in pull request #4428: Proper error handling in Hive Queries
URL: https://github.com/apache/incubator-superset/pull/4428#discussion_r191330092
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -841,6 +841,16 @@ def fetch_result_sets(cls, db, datasource_type, force=False):
         return BaseEngineSpec.fetch_result_sets(
             db, datasource_type, force=force)
 
+    @classmethod
+    def fetch_data(cls, cursor, limit):
+        from TCLIService import ttypes
+        state = cursor.poll()
+        if state.operationState == ttypes.TOperationState.ERROR_STATE:
+            raise Exception('Query error', state.errorMessage)
+        if cls.limit_method == LimitMethod.FETCH_MANY:
 
 Review comment:
   Done.
   Sorry for delay. I was on the vacations :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org