[GitHub] [skywalking] wu-sheng commented on issue #2930: One more time for heigher performance

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #2930: One more time for heigher performance
URL: https://github.com/apache/skywalking/pull/2930#issuecomment-504620862
 
 
   > The V3 algorithms is the same as v2, and I'm learning that AtomicRangeInteger V2 value is a false-sharing with the startValue and endValue, in the v3 implementation it was disabled the false-sharing with a 64 byte array to store the value , so get the startValue or endValue can use the CPU's L1 cache line.
   
   First, the CI is still failing, please fix. Then could you point me to someplace to learn about `how is this making sure that benefit from the L1 cache`? I have read the test result and saw the increase. But honestly, this is out of my knowledge, so I need to learn and review. So basically, I need yours helps to get me through this.
   
   @kezhenxu94 @JaredTan95 @hanahmily @IanCao or any other @apache/skywalking-committers if you have this field knowledge, please review and help me on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services