You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/28 19:39:46 UTC
[GitHub] [spark] karenfeng opened a new pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
karenfeng opened a new pull request #33560:
URL: https://github.com/apache/spark/pull/33560
### What changes were proposed in this pull request?
Adds ANSI/ISO SQLSTATE standards to the error guidelines.
### Why are the changes needed?
Provides visibility and consistency to the SQLSTATEs assigned to error classes.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not needed; docs only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891426186
**[Test build #141968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141968/testReport)** for PR 33560 at commit [`bc2923d`](https://github.com/apache/spark/commit/bc2923ddf01cd4f5ccac29951deff1b98a010425).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888657683
**[Test build #141788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141788/testReport)** for PR 33560 at commit [`bc2923d`](https://github.com/apache/spark/commit/bc2923ddf01cd4f5ccac29951deff1b98a010425).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891444345
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888622894
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888600036
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888661360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33560:
URL: https://github.com/apache/spark/pull/33560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888571018
**[Test build #141786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141786/testReport)** for PR 33560 at commit [`f68ee78`](https://github.com/apache/spark/commit/f68ee785253c1221721bd86311b575847d5eaa3f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888661360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888632859
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891473441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891526878
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33560:
URL: https://github.com/apache/spark/pull/33560#discussion_r681351358
##########
File path: core/src/main/resources/error/README.md
##########
@@ -79,16 +79,177 @@ The message format accepts string parameters via the C-style printf syntax.
The quality of the error message should match the
[guidelines](https://spark.apache.org/error-message-guidelines.html).
-Invariants:
+#### Invariants
- Unique
### SQLSTATE
SQLSTATE is an optional portable error identifier across SQL engines.
For consistency, Spark only sets SQLSTATE as defined in the ANSI/ISO standard.
-Spark does not define its own classes or subclasses.
+SQLSTATE comprises a 2-character class value followed by a 3-character subclass value.
+Spark only uses the standard-defined classes and subclasses, and does not use implementation-defined classes or subclasses.
-Invariants:
+#### Invariants
- Consistent across releases
+
+#### ANSI/ISO standard
+
+The following SQLSTATEs are from ISO/IEC CD 9075-2.
+
+|SQLSTATE|Class|Condition |Subclass|Subcondition |
+|--------|-----|------------------------------------------------------------|--------|---------------------------------------------------------------|
+|07000 |07 |dynamic SQL error |000 |(no subclass) |
Review comment:
no biggie but should we capitalize it? I don't know. will leave it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891422821
@karenfeng mind retriggering https://github.com/karenfeng/spark-1/actions/runs/1076224359?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888619989
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888649291
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891473441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888632859
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891422788
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891485688
**[Test build #141968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141968/testReport)** for PR 33560 at commit [`bc2923d`](https://github.com/apache/spark/commit/bc2923ddf01cd4f5ccac29951deff1b98a010425).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891497592
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891461776
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46479/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891426186
**[Test build #141968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141968/testReport)** for PR 33560 at commit [`bc2923d`](https://github.com/apache/spark/commit/bc2923ddf01cd4f5ccac29951deff1b98a010425).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888600321
**[Test build #141788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141788/testReport)** for PR 33560 at commit [`bc2923d`](https://github.com/apache/spark/commit/bc2923ddf01cd4f5ccac29951deff1b98a010425).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888571018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33560: [SPARK-36331] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-888654634
**[Test build #141786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141786/testReport)** for PR 33560 at commit [`f68ee78`](https://github.com/apache/spark/commit/f68ee785253c1221721bd86311b575847d5eaa3f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on a change in pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #33560:
URL: https://github.com/apache/spark/pull/33560#discussion_r681416650
##########
File path: core/src/main/resources/error/README.md
##########
@@ -79,16 +79,177 @@ The message format accepts string parameters via the C-style printf syntax.
The quality of the error message should match the
[guidelines](https://spark.apache.org/error-message-guidelines.html).
-Invariants:
+#### Invariants
- Unique
### SQLSTATE
SQLSTATE is an optional portable error identifier across SQL engines.
For consistency, Spark only sets SQLSTATE as defined in the ANSI/ISO standard.
-Spark does not define its own classes or subclasses.
+SQLSTATE comprises a 2-character class value followed by a 3-character subclass value.
+Spark only uses the standard-defined classes and subclasses, and does not use implementation-defined classes or subclasses.
-Invariants:
+#### Invariants
- Consistent across releases
+
+#### ANSI/ISO standard
+
+The following SQLSTATEs are from ISO/IEC CD 9075-2.
+
+|SQLSTATE|Class|Condition |Subclass|Subcondition |
+|--------|-----|------------------------------------------------------------|--------|---------------------------------------------------------------|
+|07000 |07 |dynamic SQL error |000 |(no subclass) |
Review comment:
I don't particularly care either way. Given that this is pulled directly from the SQL manual and this is the style they went with, I'm ok with keeping it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33560: [SPARK-36331][CORE] Add standard SQLSTATEs to error guidelines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33560:
URL: https://github.com/apache/spark/pull/33560#issuecomment-891497592
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org