You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:05:26 UTC

[GitHub] [arrow] cyb70289 commented on pull request #7920: ARROW-9638: [C++][Compute] Implement mode kernel

cyb70289 commented on pull request #7920:
URL: https://github.com/apache/arrow/pull/7920#issuecomment-671162987


   From CI failure, looks different platform/compiler handles NaN differently.
   
   Would like to ask for comments: **should NaN be ignored or included in mode calculation**.
   Per my test, scipy ignores NaN.
   
   ```
   In [3]: scipy.stats.mode([np.nan, np.nan, 1], nan_policy='propagate')
   Out[3]: ModeResult(mode=array([1.]), count=array([1]))
   
   In [4]: scipy.stats.mode([np.nan, np.nan, 1], nan_policy='omit')
   Out[4]: ModeResult(mode=array([1.]), count=array([1.]))
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org