You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2018/10/16 14:26:49 UTC

httpcomponents-client git commit: HttpAuthenticator to re-use the logger of its parent

Repository: httpcomponents-client
Updated Branches:
  refs/heads/master ac9034203 -> 447e276fb


HttpAuthenticator to re-use the logger of its parent


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/447e276f
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/447e276f
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/447e276f

Branch: refs/heads/master
Commit: 447e276fb698faeca36cc94d6738dd7e27d1f7e7
Parents: ac90342
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Tue Oct 16 16:18:25 2018 +0200
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Tue Oct 16 16:18:25 2018 +0200

----------------------------------------------------------------------
 .../org/apache/hc/client5/http/impl/async/AsyncConnectExec.java    | 2 +-
 .../org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java   | 2 +-
 .../org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java    | 2 ++
 .../java/org/apache/hc/client5/http/impl/classic/ConnectExec.java  | 2 +-
 .../java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java | 2 +-
 5 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/447e276f/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncConnectExec.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncConnectExec.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncConnectExec.java
index 577f44b..acf3191 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncConnectExec.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncConnectExec.java
@@ -90,7 +90,7 @@ public final class AsyncConnectExec implements AsyncExecChainHandler {
         Args.notNull(proxyAuthStrategy, "Proxy authentication strategy");
         this.proxyHttpProcessor = proxyHttpProcessor;
         this.proxyAuthStrategy  = proxyAuthStrategy;
-        this.authenticator      = new HttpAuthenticator();
+        this.authenticator      = new HttpAuthenticator(log);
         this.routeDirector      = new BasicRouteDirector();
     }
 

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/447e276f/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java
index 1fa9a50..f74e817 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncProtocolExec.java
@@ -94,7 +94,7 @@ class AsyncProtocolExec implements AsyncExecChainHandler {
         this.httpProcessor = Args.notNull(httpProcessor, "HTTP protocol processor");
         this.targetAuthStrategy = Args.notNull(targetAuthStrategy, "Target authentication strategy");
         this.proxyAuthStrategy = Args.notNull(proxyAuthStrategy, "Proxy authentication strategy");
-        this.authenticator = new HttpAuthenticator();
+        this.authenticator = new HttpAuthenticator(log);
     }
 
     @Override

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/447e276f/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java
index 20b480c..b8968bc 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/HttpAuthenticator.java
@@ -45,6 +45,7 @@ import org.apache.hc.client5.http.auth.ChallengeType;
 import org.apache.hc.client5.http.auth.CredentialsProvider;
 import org.apache.hc.client5.http.auth.MalformedChallengeException;
 import org.apache.hc.client5.http.protocol.HttpClientContext;
+import org.apache.hc.core5.annotation.Internal;
 import org.apache.hc.core5.http.FormattedHeader;
 import org.apache.hc.core5.http.Header;
 import org.apache.hc.core5.http.HttpHeaders;
@@ -69,6 +70,7 @@ public class HttpAuthenticator {
     private final Logger log;
     private final AuthChallengeParser parser;
 
+    @Internal
     public HttpAuthenticator(final Logger log) {
         super();
         this.log = log != null ? log : LoggerFactory.getLogger(getClass());

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/447e276f/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java
index 0588465..410a8da 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ConnectExec.java
@@ -91,7 +91,7 @@ public final class ConnectExec implements ExecChainHandler {
         this.reuseStrategy      = reuseStrategy;
         this.proxyHttpProcessor = proxyHttpProcessor;
         this.proxyAuthStrategy  = proxyAuthStrategy;
-        this.authenticator      = new HttpAuthenticator();
+        this.authenticator      = new HttpAuthenticator(log);
         this.routeDirector      = new BasicRouteDirector();
     }
 

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/447e276f/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
index b67b4ee..10d0c56 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java
@@ -94,7 +94,7 @@ final class ProtocolExec implements ExecChainHandler {
         this.httpProcessor = Args.notNull(httpProcessor, "HTTP protocol processor");
         this.targetAuthStrategy = Args.notNull(targetAuthStrategy, "Target authentication strategy");
         this.proxyAuthStrategy = Args.notNull(proxyAuthStrategy, "Proxy authentication strategy");
-        this.authenticator = new HttpAuthenticator();
+        this.authenticator = new HttpAuthenticator(log);
     }
 
     @Override