You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/13 19:09:09 UTC

Review Request 38337: Extract gz file in fetcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-3407
    https://issues.apache.org/jira/browse/MESOS-3407


Repository: mesos


Description
-------

Extract gz file in fetcher.


Diffs
-----

  src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
  src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 

Diff: https://reviews.apache.org/r/38337/diff/


Testing
-------

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" --verbose


Thanks,

haosdent huang


Re: Review Request 38337: Extract gz file in fetcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/#review98775
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38337]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 5:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38337/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3407
>     https://issues.apache.org/jira/browse/MESOS-3407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extract gz file in fetcher.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
>   src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 
> 
> Diff: https://reviews.apache.org/r/38337/diff/
> 
> 
> Testing
> -------
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38337: Extract gz file in fetcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/#review101409
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38337]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:05 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38337/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-3407
>     https://issues.apache.org/jira/browse/MESOS-3407
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extract gz file in fetcher.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
>   src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 
> 
> Diff: https://reviews.apache.org/r/38337/diff/
> 
> 
> Testing
> -------
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38337: Extract gz file in fetcher.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38337/
-----------------------------------------------------------

(Updated Oct. 3, 2015, 4:05 p.m.)


Review request for mesos, Adam B and Timothy Chen.


Changes
-------

Rebase


Bugs: MESOS-3407
    https://issues.apache.org/jira/browse/MESOS-3407


Repository: mesos


Description
-------

Extract gz file in fetcher.


Diffs (updated)
-----

  src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff 
  src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 

Diff: https://reviews.apache.org/r/38337/diff/


Testing
-------

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" --verbose


Thanks,

haosdent huang