[incubator-superset] branch fix/long-table-names created (now a9e91ef)

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

suddjian pushed a change to branch fix/long-table-names
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at a9e91ef  display the full table name in a tooltip

This branch includes the following new commits:

     new 19cb561  widen the autocomplete menu for table names
     new a9e91ef  display the full table name in a tooltip

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[incubator-superset] 02/02: display the full table name in a tooltip

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

suddjian pushed a commit to branch fix/long-table-names
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit a9e91ef668db58d8e5027c0c90acb8b60a41b3a6
Author: David Aaron Suddjian <aa...@gmail.com>
AuthorDate: Tue Aug 4 12:33:09 2020 -0700

    display the full table name in a tooltip
---
 superset-frontend/src/components/TableSelector.jsx | 25 ++++++++++++++--------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/superset-frontend/src/components/TableSelector.jsx b/superset-frontend/src/components/TableSelector.jsx
index 922fdd6..677663d 100644
--- a/superset-frontend/src/components/TableSelector.jsx
+++ b/superset-frontend/src/components/TableSelector.jsx
@@ -30,6 +30,7 @@ import FormLabel from 'src/components/FormLabel';
 import SupersetAsyncSelect from './AsyncSelect';
 import RefreshLabel from './RefreshLabel';
 import './TableSelector.less';
+import TooltipWrapper from './TooltipWrapper';
 
 const FieldTitle = styled.p`
   color: ${({ theme }) => theme.colors.secondary.light2};
@@ -257,16 +258,22 @@ export default class TableSelector extends React.PureComponent {
 
   renderTableOption(option) {
     return (
-      <span className="TableLabel">
-        <span className="m-r-5">
-          <small className="text-muted">
-            <i
-              className={`fa fa-${option.type === 'view' ? 'eye' : 'table'}`}
-            />
-          </small>
+      <TooltipWrapper
+        placement="top"
+        label={`${option.label}-tooltip`}
+        tooltip={option.label}
+      >
+        <span className="TableLabel">
+          <span className="m-r-5">
+            <small className="text-muted">
+              <i
+                className={`fa fa-${option.type === 'view' ? 'eye' : 'table'}`}
+              />
+            </small>
+          </span>
+          {option.label}
         </span>
-        {option.label}
-      </span>
+      </TooltipWrapper>
     );
   }
 

[incubator-superset] 01/02: widen the autocomplete menu for table names

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

suddjian pushed a commit to branch fix/long-table-names
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 19cb56169497113c17959386cf61d717a23f0d74
Author: David Aaron Suddjian <aa...@gmail.com>
AuthorDate: Mon Aug 3 23:35:35 2020 -0700

    widen the autocomplete menu for table names
---
 .../src/SqlLab/components/AceEditorWrapper/AceStyles.less          | 3 +++
 .../{AceEditorWrapper.tsx => AceEditorWrapper/index.tsx}           | 7 ++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper/AceStyles.less b/superset-frontend/src/SqlLab/components/AceEditorWrapper/AceStyles.less
new file mode 100644
index 0000000..6b8cc6f
--- /dev/null
+++ b/superset-frontend/src/SqlLab/components/AceEditorWrapper/AceStyles.less
@@ -0,0 +1,3 @@
+.ace_editor.ace_autocomplete {
+  width: 520px;
+}
diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx b/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
similarity index 97%
rename from superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx
rename to superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
index 370cdbc..ea63414 100644
--- a/superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx
+++ b/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
@@ -22,14 +22,15 @@ import 'brace/mode/sql';
 import 'brace/theme/github';
 import 'brace/ext/language_tools';
 import ace from 'brace';
-import { areArraysShallowEqual } from '../../reduxUtils';
-import sqlKeywords from '../utils/sqlKeywords';
+import { areArraysShallowEqual } from 'src/reduxUtils';
+import sqlKeywords from '../../utils/sqlKeywords';
 import {
   SCHEMA_AUTOCOMPLETE_SCORE,
   TABLE_AUTOCOMPLETE_SCORE,
   COLUMN_AUTOCOMPLETE_SCORE,
   SQL_FUNCTIONS_AUTOCOMPLETE_SCORE,
-} from '../constants';
+} from '../../constants';
+import './AceStyles.less';
 
 const langTools = ace.acequire('ace/ext/language_tools');