You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/03 21:02:52 UTC
[GitHub] [openwhisk] tysonnorris opened a new pull request #4961: Kubernetes - delete pod on api failure
tysonnorris opened a new pull request #4961:
URL: https://github.com/apache/openwhisk/pull/4961
<!--- Provide a concise summary of your changes in the Title -->
## Description
Current behavior is that exception from the api call to create a pod, does NOT attempt to delete the pod that was just referenced. Original thought was that if the api call was unsuccessful, there would be nothing to cleanup. But we've seen other cases where the api call fails, and yet the pod is still created (and therefore becomes orphaned).
With this PR, on an error from kubernetes api server (whether a response error, or some exception from fabric8 client, doesn't matter), now we attempt to delete the pod which may or may not have been created.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [x] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [x] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] tysonnorris merged pull request #4961: Kubernetes - delete pod on api failure
Posted by GitBox <gi...@apache.org>.
tysonnorris merged pull request #4961:
URL: https://github.com/apache/openwhisk/pull/4961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] tysonnorris merged pull request #4961: Kubernetes - delete pod on api failure
Posted by GitBox <gi...@apache.org>.
tysonnorris merged pull request #4961:
URL: https://github.com/apache/openwhisk/pull/4961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org