You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Ankita Agarwal (Jira)" <ji...@apache.org> on 2021/10/05 08:14:00 UTC
[jira] [Comment Edited] (OAK-9591) Implement hashcode() and
equals() method in ItemDefinitionImpl
[ https://issues.apache.org/jira/browse/OAK-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424348#comment-17424348 ]
Ankita Agarwal edited comment on OAK-9591 at 10/5/21, 8:13 AM:
---------------------------------------------------------------
[~thomasm]
The idea is:
* get the {{NodeDefinition}} of the child node that is to be deleted.
* loop through all child nodes and count the ones that have the same nodedef. {color:#00875a}To compare that the nodedef is same, it was recommended to add an equals method in ItemDefinitionImpl as per the conversation done on PR [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698] {color}
* if the nodedef is mandatory and there are more than 1 nodes with this nodedef, we can delete it.
was (Author: ankitaagar):
[~thomasm]
The idea is:
* get the {{NodeDefinition}} of the child node that is to be deleted.
* loop through all child nodes and count the ones that have the same nodedef. {color:#00875a}To compare that the nodedef is same it was recommended to add an equals method in ItemDefinitionImpl as per the conversation done on PR [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698] {color}
* if the nodedef is mandatory and there are more than 1 nodes with this nodedef, we can delete it.
> Implement hashcode() and equals() method in ItemDefinitionImpl
> --------------------------------------------------------------
>
> Key: OAK-9591
> URL: https://issues.apache.org/jira/browse/OAK-9591
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 1.40.0
> Reporter: Ankita Agarwal
> Priority: Major
> Fix For: 1.42.0
>
>
> The idea is:
> * get the {{NodeDefinition}} of the child node that is to be deleted.
> * loop through all child nodes and count the ones that have the same nodedef. {color:#00875a}To compare that the nodedef is same, it was recommended to add an equals method in ItemDefinitionImpl as per the conversation done on PR [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698] {color}
> * if the nodedef is mandatory and there are more than 1 nodes with this nodedef, we can delete it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)