You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2017/09/27 17:11:04 UTC
Review Request 62621: Allow transitions from any state to STOPPED in
CallOrderEnforcingStorage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/
-----------------------------------------------------------
Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
Repository: aurora
Description
-------
- Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
- Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
Diff: https://reviews.apache.org/r/62621/diff/1/
Testing
-------
No unit tests specified.
./gradlew test
Thanks,
Jordan Ly
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186439
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 27, 2017, 10:11 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 10:11 a.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
>
>
> Diff: https://reviews.apache.org/r/62621/diff/1/
>
>
> Testing
> -------
>
> No unit tests specified.
> ./gradlew test
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186455
-----------------------------------------------------------
Master (474320b) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 5:25 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 5:25 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
>
>
> Diff: https://reviews.apache.org/r/62621/diff/3/
>
>
> Testing
> -------
>
> No unit tests specified.
> ./gradlew test
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186446
-----------------------------------------------------------
@ReviewBot retry
- Jordan Ly
On Sept. 27, 2017, 5:25 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 5:25 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
>
>
> Diff: https://reviews.apache.org/r/62621/diff/3/
>
>
> Testing
> -------
>
> No unit tests specified.
> ./gradlew test
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186464
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Sept. 27, 2017, 9:27 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:27 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
>
>
> Bugs: AURORA-1950
> https://issues.apache.org/jira/browse/AURORA-1950
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
>
>
> Diff: https://reviews.apache.org/r/62621/diff/3/
>
>
> Testing
> -------
>
> No unit tests specified.
> ./gradlew test
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 9:27 p.m.)
Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
Changes
-------
Add refernece to related issue.
Bugs: AURORA-1950
https://issues.apache.org/jira/browse/AURORA-1950
Repository: aurora
Description
-------
- Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
- Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
Diff: https://reviews.apache.org/r/62621/diff/3/
Testing
-------
No unit tests specified.
./gradlew test
Thanks,
Jordan Ly
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186445
-----------------------------------------------------------
Master (474320b) is red with this patch.
./build-support/jenkins/build.sh
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
curl: (35) gnutls_handshake() failed: Error in the pull function.
Makefile:49: recipe for target 'thrift-0.9.1/compiler/cpp/thrift' failed
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 34s
7 actionable tasks: 1 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 5:25 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 5:25 p.m.)
>
>
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
>
>
> Diff: https://reviews.apache.org/r/62621/diff/3/
>
>
> Testing
> -------
>
> No unit tests specified.
> ./gradlew test
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 62621: Allow transitions from any state to STOPPED
in CallOrderEnforcingStorage
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 5:25 p.m.)
Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
Changes
-------
Was getting checkstyle exception, needed to propogate the cause of the exception.
Repository: aurora
Description
-------
- Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
- Use the StateMachines.checkState method (I wasn't sure if the current checkInState was designed for anything other than throwing a TransientStorageException)
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c
Diff: https://reviews.apache.org/r/62621/diff/2/
Changes: https://reviews.apache.org/r/62621/diff/1-2/
Testing
-------
No unit tests specified.
./gradlew test
Thanks,
Jordan Ly