[GitHub] [arrow-rs] alamb commented on a diff in pull request #4571: Move chrono-tz arithmetic tests to integration

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4571:
URL: https://github.com/apache/arrow-rs/pull/4571#discussion_r1275426891


##########
arrow-arith/Cargo.toml:
##########
@@ -46,4 +46,3 @@ num = { version = "0.4", default-features = false, features = ["std"] }
 
 [features]
 simd = ["arrow-array/simd"]
-chrono-tz = ["arrow-array/chrono-tz"]

Review Comment:
   isn't this technically a breaking change for anyone using https://crates.io/crates/arrow-arith directly with this feature? I doubt anyone will notice, but I do think we should flag the PR as API change



##########
arrow/Cargo.toml:
##########
@@ -300,3 +300,7 @@ required-features = ["chrono-tz", "prettyprint"]
 [[test]]
 name = "timezone"
 required-features = ["chrono-tz"]
+
+[[test]]
+name = "arithmetic"
+required-features = ["chrono-tz"]

Review Comment:
   arithmetic is a fairly general name that only has timezone related tests now -- do you plan to move more tests there over time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org