You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/16 11:39:16 UTC

[GitHub] [druid] petermarshallio opened a new pull request #11926: Docs - Corrected admonition issue

petermarshallio opened a new pull request #11926:
URL: https://github.com/apache/druid/pull/11926


   Corrected an underlying MD issue on this page that caused the admonition to be incorrectly rendered.
   
   This PR has:
   - [X] been self-reviewed.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] petermarshallio commented on pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
petermarshallio commented on pull request #11926:
URL: https://github.com/apache/druid/pull/11926#issuecomment-971551611


   @kfaraz I thought I'd have a go at rewording the intimidating sentence while I was there...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz commented on a change in pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
kfaraz commented on a change in pull request #11926:
URL: https://github.com/apache/druid/pull/11926#discussion_r750337751



##########
File path: docs/ingestion/data-formats.md
##########
@@ -598,8 +598,10 @@ For example:
   ]
 }
 ```
-After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
-> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec). Keep this in mind when writing your ingestion spec.
+> After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as
+> [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
+> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec).
+> Keep this in mind when writing your ingestion spec.

Review comment:
       This line seems redundant (and perhaps a bit intimidating too 😛 ) now that the whole thing is a quoted block.
   Should we get rid of it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] petermarshallio commented on a change in pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
petermarshallio commented on a change in pull request #11926:
URL: https://github.com/apache/druid/pull/11926#discussion_r751206903



##########
File path: docs/ingestion/data-formats.md
##########
@@ -598,8 +598,10 @@ For example:
   ]
 }
 ```
-After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
-> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec). Keep this in mind when writing your ingestion spec.
+> After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as
+> [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
+> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec).
+> Keep this in mind when writing your ingestion spec.

Review comment:
       Ha!  I think @techdocsmith would definitely agree with you on the admonition part haha. I wonder maybe if it was an MD edit error when one of the > were left in and it should have been taken out.  I think it's important people know the order that this is applied in, though, so the content is probably useful to keep in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] techdocsmith merged pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
techdocsmith merged pull request #11926:
URL: https://github.com/apache/druid/pull/11926


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] petermarshallio commented on pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
petermarshallio commented on pull request #11926:
URL: https://github.com/apache/druid/pull/11926#issuecomment-970187158


   @techdocsmith a quick one for ya!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] petermarshallio closed pull request #11926: Docs - Corrected admonition issue

Posted by GitBox <gi...@apache.org>.
petermarshallio closed pull request #11926:
URL: https://github.com/apache/druid/pull/11926


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org