You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/31 16:00:10 UTC
[GitHub] [iceberg] JonasJ-ap opened a new pull request, #5680: AWS: fix the wrong flag used for s3UseArnRegionEnabled
JonasJ-ap opened a new pull request, #5680:
URL: https://github.com/apache/iceberg/pull/5680
In [aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java, line 99](https://github.com/apache/iceberg/blob/6a1f351414227f5c09235a96ad579fab0e88733a/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java#L99),
the `initialize` method use `AwsProperties.S3_ACCESS_POINTS_PREFIX` to update the `this.s3UseArnRegionEnabled` field:
```
this.s3UseArnRegionEnabled =
PropertyUtil.propertyAsBoolean(
properties,
AwsProperties.S3_ACCESS_POINTS_PREFIX,
AwsProperties.S3_USE_ARN_REGION_ENABLED_DEFAULT);
```
According to: https://aws.amazon.com/s3/features/access-points/, the `S3_ACCESS_POINTS_PREFIX` contains the name of the access point rather than `true/false` values. Initializing the feature in this way makes this feature `disabled` almost all the time.
Hence, it seems we need to use `S3_USE_ARN_REGION_ENABLED` here instead, like the initialization happens in [aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java, line 152](https://github.com/apache/iceberg/blob/6a1f351414227f5c09235a96ad579fab0e88733a/aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java#L159).
```
this.s3UseArnRegionEnabled =
PropertyUtil.propertyAsBoolean(
properties,
AwsProperties.S3_USE_ARN_REGION_ENABLED,
AwsProperties.S3_USE_ARN_REGION_ENABLED_DEFAULT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #5680: AWS: fix the wrong flag used for s3UseArnRegionEnabled
Posted by GitBox <gi...@apache.org>.
jackye1995 merged PR #5680:
URL: https://github.com/apache/iceberg/pull/5680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org