You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by sdumitriu <gi...@git.apache.org> on 2014/12/30 07:13:07 UTC
[GitHub] lucene-solr pull request: Fixed a typo in various solrconfig.xml f...
GitHub user sdumitriu opened a pull request:
https://github.com/apache/lucene-solr/pull/120
Fixed a typo in various solrconfig.xml files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdumitriu/lucene-solr typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 6848c9c4ad85f78d2f6c1b90a122cb28c4413686
Author: Sergiu Dumitriu <se...@phenotips.org>
Date: 2014-12-30T06:11:36Z
Fixed a typo in various solrconfig.xml files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Fixed a typo in various solrconfig.xml f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #120: SOLR-4735 Improve Solr metrics reporting
Posted by randomstatistic <gi...@git.apache.org>.
Github user randomstatistic commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/120#discussion_r90144072
--- Diff: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java ---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.metrics;
+
+import java.util.Set;
+
+import com.codahale.metrics.Counter;
+import com.codahale.metrics.Histogram;
+import com.codahale.metrics.Meter;
+import com.codahale.metrics.MetricFilter;
+import com.codahale.metrics.MetricRegistry;
+import com.codahale.metrics.SharedMetricRegistries;
+import com.codahale.metrics.Snapshot;
+import com.codahale.metrics.Timer;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ *
+ */
+public class SolrMetricManager {
+
+ public static final String REGISTRY_NAME_PREFIX = "solr";
+ public static final String DEFAULT_REGISTRY = MetricRegistry.name(REGISTRY_NAME_PREFIX, "default");
+
+ // don't create instances of this class
+ private SolrMetricManager() { }
+
+
+ /**
+ * Return a set of existing registry names.
+ */
+ public static Set<String> registryNames() {
+ return SharedMetricRegistries.names();
+ }
+
+ /**
+ * Get (or create if not present) a named registry
+ * @param registry name of the registry
+ * @return existing or newly created registry
+ */
+ public static MetricRegistry registryFor(String registry) {
+ return SharedMetricRegistries.getOrCreate(overridableRegistryName(registry));
+ }
+
+ /**
+ * Remove all metrics from a specified registry.
+ * @param registry registry name
+ */
+ public static void clearRegistryFor(String registry) {
+ SharedMetricRegistries.getOrCreate(overridableRegistryName(registry)).removeMatching(MetricFilter.ALL);
--- End diff --
This, and several other places below could delegate to `registryFor(registry)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org