You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Joseph Wolschon (JIRA)" <ji...@apache.org> on 2014/12/15 20:54:13 UTC
[jira] [Commented] (WW-4433) ConventionUnknownHandler change breaks
exception handling in interceptors.
[ https://issues.apache.org/jira/browse/WW-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247139#comment-14247139 ]
Joseph Wolschon commented on WW-4433:
-------------------------------------
An improper deprecation was also added to the interface that makes it unclear if this is an intentional deprecation to UnknownHandler implementation or a change to default Struts behavior: https://fisheye6.atlassian.com/browse/struts/xwork-core/src/main/java/com/opensymphony/xwork2/UnknownHandler.java?r1=0c543aef318341ca9bd482e15f1637497b8a4dfd&r2=ff100ce2d9c939e9cf4867bc46966a7dfecb6770.
> ConventionUnknownHandler change breaks exception handling in interceptors.
> --------------------------------------------------------------------------
>
> Key: WW-4433
> URL: https://issues.apache.org/jira/browse/WW-4433
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors, Documentation, Plugin - Convention
> Affects Versions: 2.3.20
> Reporter: Joseph Wolschon
> Priority: Minor
>
> Struts 2.3.20 appears to have caused a regression that prevents exceptions thrown from convention-plugin actions from reaching ExceptionMappingInterceptor. This breaks exception handling when using the convention-plugin.
> To Reproduce:
> * Generate a project struts2-archetype-convention archetype using 2.3.20
> * Throw exception in the action. With 2.3.20, a blank page is shown.
> * Change to 2.3.16.3 and you will get the standard struts2 error page.
> The breaking change appears to have been made in WW-4331: https://issues.apache.org/jira/browse/WW-4331. This causes error interceptor code to break (showing a blank page when exceptions are thrown) as DefaultActionInvocation does not catch an exception from the default UnknownHandler implementation execution, which would previously re-throw the original exception back up for the interceptors to catch.
> Workaround:
> We've created our own UnknownHandler implementation that just throws a new NoSuchMethodException, allowing DefaultActionInvocation to re-throw the original exception so that our error interceptor can again catch it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)