[GitHub] [accumulo-testing] phrocker commented on a change in pull request #119: Add asynchronous input format and bulk key.

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #119: Add asynchronous input format and bulk key.
URL: https://github.com/apache/accumulo-testing/pull/119#discussion_r350723715
 
 

 ##########
 File path: src/main/java/org/apache/accumulo/testing/continuous/BulkIngest.java
 ##########
 @@ -60,25 +58,29 @@ public int run(String[] args) throws Exception {
 
     log.info(String.format("UUID %d %s", System.currentTimeMillis(), ingestInstanceId));
 
-    job.setInputFormatClass(ContinuousInputFormat.class);
-
-    // map the generated random longs to key values
-    job.setMapOutputKeyClass(Key.class);
-    job.setMapOutputValueClass(Value.class);
-
     String bulkDir = args[0];
 
     // remove bulk dir from args
     args = Arrays.asList(args).subList(1, 3).toArray(new String[2]);
 
     try (ContinuousEnv env = new ContinuousEnv(args)) {
+
+      /**
+       * Support various Input Formats
+       */
+      job.setInputFormatClass(env.getInputFormat());
 
 Review comment:
   I made this change as I was submitting the PR so I will run some quick tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services