You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/02/17 00:30:15 UTC
Review Request 65694: Made the default executor's handling of kill
escalations more robust.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65694/
-----------------------------------------------------------
Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.
Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530
Repository: mesos
Description
-------
This patch makes the default executor retry SIGKILL escalations if the
it is disconnected from the agent or the kill call fails.
Diffs
-----
src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407
Diff: https://reviews.apache.org/r/65694/diff/1/
Testing
-------
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65694: Made the default executor's handling of kill
escalations more robust.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65694/
-----------------------------------------------------------
(Updated March 16, 2018, 12:53 p.m.)
Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530
Repository: mesos
Description
-------
This patch makes the default executor retry SIGKILL escalations if the
executor is disconnected from the agent or the kill call fails.
Diffs (updated)
-----
src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84
Diff: https://reviews.apache.org/r/65694/diff/3/
Changes: https://reviews.apache.org/r/65694/diff/2-3/
Testing
-------
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65694: Made the default executor's handling of kill
escalations more robust.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65694/
-----------------------------------------------------------
(Updated March 7, 2018, 6:07 p.m.)
Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.
Changes
-------
Fixed a typo in the patch description.
Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530
Repository: mesos
Description (updated)
-------
This patch makes the default executor retry SIGKILL escalations if the
executor is disconnected from the agent or the kill call fails.
Diffs (updated)
-----
src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84
Diff: https://reviews.apache.org/r/65694/diff/2/
Changes: https://reviews.apache.org/r/65694/diff/1-2/
Testing
-------
`sudo bin/mesos-tests.sh` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65694: Made the default executor's handling of kill
escalations more robust.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65694/#review198833
-----------------------------------------------------------
Ship it!
LGTM.
Note to self: `s/it/executor/` in the commit description.
- Joseph Wu
On Feb. 16, 2018, 4:30 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65694/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 4:30 p.m.)
>
>
> Review request for mesos, Joseph Wu, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8530
> https://issues.apache.org/jira/browse/MESOS-8530
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the default executor retry SIGKILL escalations if the
> it is disconnected from the agent or the kill call fails.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407
>
>
> Diff: https://reviews.apache.org/r/65694/diff/1/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>