[GitHub] [helix] xyuanlu commented on a diff in pull request #2208: Unnecessary log removal

[GitBox <gi...@apache.org>]

xyuanlu commented on code in PR #2208:
URL: https://github.com/apache/helix/pull/2208#discussion_r967274664


##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackEventThreadPoolFactory.java:
##########
@@ -83,8 +83,6 @@ private static ThreadPoolExecutor getOrCreateThreadPoolHelper(int hash) {
         _managerToCallBackThreadPoolMap.put(hash, result);
         _callBackEventProcessorCountPerThreadPool.put(hash, new AtomicInteger(1));
       } catch (Exception e) {
-        logger.error(String
-            .format("Error when creating new ThreadPoolExecutor for %s.", hash), e);

Review Comment:
   If we catch and throw, do we need to actually catch it here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org