You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ethe (via GitHub)" <gi...@apache.org> on 2025/03/16 10:50:19 UTC
[PR] chore: require ffi feature in arrow-schema benchmark [arrow-rs]
ethe opened a new pull request, #7298:
URL: https://github.com/apache/arrow-rs/pull/7298
# Rationale for this change
setting `required-features` in `[[bench]]` makes rust-analyzer happy, unless below error is linted:
```
error[E0432]: unresolved import `arrow_schema::ffi`
--> arrow-schema/benches/ffi.rs:18:19
|
18 | use arrow_schema::ffi::FFI_ArrowSchema;
| ^^^ could not find `ffi` in `arrow_schema`
|
note: found an item that was configured out
--> /Users/gwo/Idea/arrow-rs/arrow-schema/src/lib.rs:44:9
|
44 | pub mod ffi;
| ^^^
note: the item is gated behind the `ffi` feature
--> /Users/gwo/Idea/arrow-rs/arrow-schema/src/lib.rs:43:7
|
43 | #[cfg(feature = "ffi")]
| ^^^^^^^^^^^^^^^
```
# What changes are included in this PR?
modified `arrow-schema/Cargo.toml`
# Are there any user-facing changes?
no there aren't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: require ffi feature in arrow-schema benchmark [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7298:
URL: https://github.com/apache/arrow-rs/pull/7298#issuecomment-2728844663
> CI is failed but I don't think it relates to this change.
Agreed. I believe it is the same as
- https://github.com/apache/arrow-rs/issues/7291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: require ffi feature in arrow-schema benchmark [arrow-rs]
Posted by "ethe (via GitHub)" <gi...@apache.org>.
ethe commented on PR #7298:
URL: https://github.com/apache/arrow-rs/pull/7298#issuecomment-2727330852
CI is failed but I think it does not relate to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: require ffi feature in arrow-schema benchmark [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7298:
URL: https://github.com/apache/arrow-rs/pull/7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org