You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/13 20:39:57 UTC

Review Request 29859: Capture security state from components for use in enabling or disabling Kerberos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29859/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, John Speidel, and Robert Nettleton.


Bugs: AMBARI-9045
    https://issues.apache.org/jira/browse/AMBARI-9045


Repository: ambari


Description
-------

Update each component's security state using the security status value from the _heartbeat_ message.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 8403ba6 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 0533228 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 2c6b33e 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java a99628c 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 3cf3b67 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java d720da2 

Diff: https://reviews.apache.org/r/29859/diff/


Testing
-------

Manually tested in cluster to view database table updates.

Updated unit tests:

#Jenkins Test Results

Tests run: 2522, Failures: 0, Errors: 0, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:01 h
[INFO] Finished at: 2015-01-13T19:14:33+00:00
[INFO] Final Memory: 44M/526M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Re: Review Request 29859: Capture security state from components for use in enabling or disabling Kerberos

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29859/#review67945
-----------------------------------------------------------

Ship it!


Looks good.

- Robert Nettleton


On Jan. 13, 2015, 7:39 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29859/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 7:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, John Speidel, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-9045
>     https://issues.apache.org/jira/browse/AMBARI-9045
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update each component's security state using the security status value from the _heartbeat_ message.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 8403ba6 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java da4d38b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 0533228 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 2c6b33e 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java a99628c 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 3cf3b67 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java d720da2 
> 
> Diff: https://reviews.apache.org/r/29859/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in cluster to view database table updates.
> 
> Updated unit tests:
> 
> #Jenkins Test Results
> 
> Tests run: 2522, Failures: 0, Errors: 0, Skipped: 13
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:01 h
> [INFO] Finished at: 2015-01-13T19:14:33+00:00
> [INFO] Final Memory: 44M/526M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>