You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wookie.apache.org by sc...@apache.org on 2010/06/18 11:43:57 UTC
svn commit: r955912 -
/incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
Author: scottbw
Date: Fri Jun 18 09:43:56 2010
New Revision: 955912
URL: http://svn.apache.org/viewvc?rev=955912&view=rev
Log:
Fixed issue with the Widgets Controller - was using wrong logic for determining resource validity. I'm not sure how this bug got introduced though. WOOKIE-144
Modified:
incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
Modified: incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
URL: http://svn.apache.org/viewvc/incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java?rev=955912&r1=955911&r2=955912&view=diff
==============================================================================
--- incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java (original)
+++ incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java Fri Jun 18 09:43:56 2010
@@ -69,8 +69,8 @@ public class WidgetsController extends C
* @see org.apache.wookie.controller.Controller#show(java.lang.String, javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)
*/
protected void show(String resourceId, HttpServletRequest request,
- HttpServletResponse response) throws ResourceNotFoundException, IOException {
- if ((resourceId != null) && (resourceId.length() > 0)){
+ HttpServletResponse response) throws ResourceNotFoundException, IOException {
+ if (!isAnInteger(resourceId)){
index(resourceId, request, response);
return;
}
Re: svn commit: r955912 - /incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
Posted by Scott Wilson <sc...@gmail.com>.
On 18 Jun 2010, at 13:19, Randy Watler wrote:
> Scott:
>
> I will look at this a bit later, but one cannot assume ids are integers now. What was the behavior that forces this revert so that I can verify a better fix?
Hi Randy,
Ahhhh, that explains it. OK, calls to the Widgets API weren't working - e.g.
GET /wookie/widgets/0
GET /wookie/widgets/9999
There are also a couple of functional tests that cover it in WidgetsControllerTest.java
S
>
> Thanks,
>
> Randy
>
> scottbw@apache.org wrote:
>> Author: scottbw
>> Date: Fri Jun 18 09:43:56 2010
>> New Revision: 955912
>>
>> URL: http://svn.apache.org/viewvc?rev=955912&view=rev
>> Log:
>> Fixed issue with the Widgets Controller - was using wrong logic for determining resource validity. I'm not sure how this bug got introduced though. WOOKIE-144
>>
>> Modified:
>> incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
>>
>> Modified: incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
>> URL: http://svn.apache.org/viewvc/incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java?rev=955912&r1=955911&r2=955912&view=diff
>> ==============================================================================
>> --- incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java (original)
>> +++ incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java Fri Jun 18 09:43:56 2010
>> @@ -69,8 +69,8 @@ public class WidgetsController extends C
>> * @see org.apache.wookie.controller.Controller#show(java.lang.String, javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)
>> */
>> protected void show(String resourceId, HttpServletRequest request,
>> - HttpServletResponse response) throws ResourceNotFoundException, IOException {
>> - if ((resourceId != null) && (resourceId.length() > 0)){
>> + HttpServletResponse response) throws ResourceNotFoundException, IOException {
>> + if (!isAnInteger(resourceId)){
>> index(resourceId, request, response);
>> return;
>> }
>>
>>
>>
>>
>
Re: svn commit: r955912 - /incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
Posted by Randy Watler <wa...@wispertel.net>.
Scott:
I will look at this a bit later, but one cannot assume ids are integers
now. What was the behavior that forces this revert so that I can verify
a better fix?
Thanks,
Randy
scottbw@apache.org wrote:
> Author: scottbw
> Date: Fri Jun 18 09:43:56 2010
> New Revision: 955912
>
> URL: http://svn.apache.org/viewvc?rev=955912&view=rev
> Log:
> Fixed issue with the Widgets Controller - was using wrong logic for determining resource validity. I'm not sure how this bug got introduced though. WOOKIE-144
>
> Modified:
> incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
>
> Modified: incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java
> URL: http://svn.apache.org/viewvc/incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java?rev=955912&r1=955911&r2=955912&view=diff
> ==============================================================================
> --- incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java (original)
> +++ incubator/wookie/branches/pluggablepersistence/src/org/apache/wookie/controller/WidgetsController.java Fri Jun 18 09:43:56 2010
> @@ -69,8 +69,8 @@ public class WidgetsController extends C
> * @see org.apache.wookie.controller.Controller#show(java.lang.String, javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)
> */
> protected void show(String resourceId, HttpServletRequest request,
> - HttpServletResponse response) throws ResourceNotFoundException, IOException {
> - if ((resourceId != null) && (resourceId.length() > 0)){
> + HttpServletResponse response) throws ResourceNotFoundException, IOException {
> + if (!isAnInteger(resourceId)){
> index(resourceId, request, response);
> return;
> }
>
>
>
>