You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Alessandro Seganti <al...@gmail.com> on 2016/04/01 08:21:30 UTC

Re: Contributing to the code

Hi Andy,
I finally managed to make the pull request (
https://github.com/apache/jena/pull/132)!
Let me know what you think.



2016-03-18 17:46 GMT+01:00 Andy Seaborne <an...@apache.org>:

> Hi Alessandro,
>
> On 18/03/16 06:39, Alessandro Seganti wrote:
>
>> Hi,
>> I forgot another thing: is there a way to get the locale that should be
>> used for string conversion inside the
>> jena-arq/.../sparql/expr/nodevalue/XSDFuncOp class? I need this to convert
>> numbers to strings (using or not the dot).
>>
>
> In XSD, any number to string should be happening locale-independent, ie
> Locale.ROOT so the issue has never come up before.  You need to get the
> Locale in force.
>
>
> 2016-03-17 21:28 GMT+01:00 Alessandro Seganti <
>> alessandro.seganti@gmail.com>
>>
>>> Hi Andy,
>>> it took me some time to understand how the code is organized but I think
>>> that I have completed the JENA-967 task. I have still some doubts but I
>>> need to show you the code to explain my problem. I wanted to make a pull
>>> request on github but I was denied access. Do I need to do something lese
>>> before having access to the repository? My github account is under
>>> cicerone54@hotmail.com.
>>>
>>
> What should work is to fork http://github.com/apache/jena in github, work
> on the clone ("git:" URL) cloned to the local machine, then do a github UI
> "pull request".  Is that what you tried?  What access denied did you get?
>
>         Andy
>
>

Re: Contributing to the code

Posted by Andy Seaborne <an...@apache.org>.
Yes - the jena-text and jena-spatial are similar but as a fixed-term 
GSoC project, jena-spatial had to copy the code of jena-text as a 
starting point.

It would be good if they shared more - they both use Lucene.

Osma has been working on jena-text recently and may have some thoughts 
or ideas of what could be done in and around this area.

     Andy

On 20/07/16 21:42, A. Soroka wrote:
> Obviously, I can't speak for Andy, but I suspect he might have been thinking of this:
>
> https://lists.apache.org/thread.html/dce0d502b11891c28e57bbcbb0cdef27d8374d58d9634076b8ef4cd7@1431107516@%3Cdev.jena.apache.org%3E
>
> conversation. Maybe Stephen Allen can chime in? The idea of getting a common Lucene backbone between -spatial and -text sounds great. Even better would be factoring out the commonalities as a step on the road to supporting pluggable new index types!
>
> ---
> A. Soroka
> The University of Virginia Library
>
>> On Jul 20, 2016, at 4:30 PM, Alessandro Seganti <al...@gmail.com> wrote:
>>
>> Andy,
>> as the Xpath3 task is finished I am ready in starting a new task.
>> According to the list of things you wrote to me the last time, this one is
>> the one that got my attention:
>>
>> *2/ The Spatial query and text query modules share a common framework but
>> the text one has had work done on it and the spatial one hasn't. It would
>> be good to find the common framework and redo the spatial query module to
>> share the general mechanisms with the text query.*
>>
>> Could you explain a bit better what you mean? Is there a task corresponding
>> to this?
>>
>> Otherwise if you think that there are other tasks more important at the
>> moment. I am open to suggestions.
>>
>> Regards,
>> Alessandro
>>
>>
>> 2016-05-13 15:58 GMT+02:00 Andy Seaborne <an...@apache.org>:
>>
>>> Alessandro,
>>>
>>> I've added you to the Jena contributors group on JIRA.
>>>
>>> This should enable you to modify JIRA more easily.
>>>
>>> ("should" because how JIRA works in this area is a bit of a mystery to me!
>>> The project does not have it's own JIRA instance so we don't have complete
>>> flexibility over the setup.)
>>>
>>>        Andy
>>>
>>>
>


Re: Contributing to the code

Posted by "A. Soroka" <aj...@virginia.edu>.
Obviously, I can't speak for Andy, but I suspect he might have been thinking of this:

https://lists.apache.org/thread.html/dce0d502b11891c28e57bbcbb0cdef27d8374d58d9634076b8ef4cd7@1431107516@%3Cdev.jena.apache.org%3E

conversation. Maybe Stephen Allen can chime in? The idea of getting a common Lucene backbone between -spatial and -text sounds great. Even better would be factoring out the commonalities as a step on the road to supporting pluggable new index types!

---
A. Soroka
The University of Virginia Library

> On Jul 20, 2016, at 4:30 PM, Alessandro Seganti <al...@gmail.com> wrote:
> 
> Andy,
> as the Xpath3 task is finished I am ready in starting a new task.
> According to the list of things you wrote to me the last time, this one is
> the one that got my attention:
> 
> *2/ The Spatial query and text query modules share a common framework but
> the text one has had work done on it and the spatial one hasn't. It would
> be good to find the common framework and redo the spatial query module to
> share the general mechanisms with the text query.*
> 
> Could you explain a bit better what you mean? Is there a task corresponding
> to this?
> 
> Otherwise if you think that there are other tasks more important at the
> moment. I am open to suggestions.
> 
> Regards,
> Alessandro
> 
> 
> 2016-05-13 15:58 GMT+02:00 Andy Seaborne <an...@apache.org>:
> 
>> Alessandro,
>> 
>> I've added you to the Jena contributors group on JIRA.
>> 
>> This should enable you to modify JIRA more easily.
>> 
>> ("should" because how JIRA works in this area is a bit of a mystery to me!
>> The project does not have it's own JIRA instance so we don't have complete
>> flexibility over the setup.)
>> 
>>        Andy
>> 
>> 


Re: Contributing to the code

Posted by Alessandro Seganti <al...@gmail.com>.
Andy,
as the Xpath3 task is finished I am ready in starting a new task.
According to the list of things you wrote to me the last time, this one is
the one that got my attention:

*2/ The Spatial query and text query modules share a common framework but
the text one has had work done on it and the spatial one hasn't. It would
be good to find the common framework and redo the spatial query module to
share the general mechanisms with the text query.*

Could you explain a bit better what you mean? Is there a task corresponding
to this?

Otherwise if you think that there are other tasks more important at the
moment. I am open to suggestions.

Regards,
Alessandro


2016-05-13 15:58 GMT+02:00 Andy Seaborne <an...@apache.org>:

> Alessandro,
>
> I've added you to the Jena contributors group on JIRA.
>
> This should enable you to modify JIRA more easily.
>
> ("should" because how JIRA works in this area is a bit of a mystery to me!
> The project does not have it's own JIRA instance so we don't have complete
> flexibility over the setup.)
>
>         Andy
>
>

Re: Contributing to the code

Posted by Andy Seaborne <an...@apache.org>.
Alessandro,

I've added you to the Jena contributors group on JIRA.

This should enable you to modify JIRA more easily.

("should" because how JIRA works in this area is a bit of a mystery to 
me! The project does not have it's own JIRA instance so we don't have 
complete flexibility over the setup.)

	Andy


Re: Contributing to the code

Posted by Andy Seaborne <an...@apache.org>.
On 02/05/16 19:08, Alessandro Seganti wrote:
> Andy,
> I started working on task JENA-508 namely adding these fn functions:
>
> fn:normalize-space
> fn:normalize-unicode
> fn:format-number
> fn:round-half-to-even
> fn:adjust-dateTime-to-timezone
> fn:adjust-date-to-timezone
> fn:adjust-time-to-timezone
> fn:format-dateTime
> fn:format-date
> fn:format-time
>
>
> but I cannot change the status of the task. Is there something I need to do
> in order to change the status ?

Done - now marked "in progress"

(just add a comment if the system won't let you make some change)

	Andy

>
> Regards,
> Alessandro
>
>
>
>
>
> 2016-04-24 9:26 GMT+02:00 Alessandro Seganti <al...@gmail.com>:
>
>> Andy,
>> thank you for getting back to me! I will give a look to the list of things
>> you wrote to me and try to get some insight on them. 1/ and 5/ seems the
>> most feasible in the short term. 2/ and 3/ seem very interesting but I will
>> need some more info to start working on it :) Anyway if I have any
>> questions I will ask.
>>
>> Alessandro
>>
>> 2016-04-16 18:32 GMT+02:00 Andy Seaborne <an...@apache.org>:
>>
>>> On 11/04/16 18:50, Alessandro Seganti wrote:
>>>
>>>> Hi,
>>>> I was looking around but I have not found any other task. If someone has
>>>> in
>>>> mind another task that I can do just let me know.
>>>>
>>>> Regards,
>>>> Alessandro
>>>>
>>>
>>> Hi there,
>>>
>>> The tasks could use some cleaning and categorising.  IMO many of the open
>>> ended tasks over, say 2year, could be resolved "won't fix" and a note to
>>> reopen only there is new input.
>>>
>>> Anyway, some suggestions:
>>>
>>>
>>> 1/ JENA-647 : This is adding template queries to Fuseki.
>>>
>>> The idea is that server has a service where instead of a query, the
>>> requests has a template name and values for variables.  A template lists
>>> some variables that must be defined as part of its definition in an
>>> assembler.
>>>
>>> Such a service means a published dataset can have just a fixed set of
>>> template queries to access it.
>>>
>>> http://localhost/3030/ds/template?id=nameoftemplat&var_A=<http://example
>>>> &var_B=123
>>>
>>> First step is to write a design.
>>>
>>> 2/ The Spatial query and text query modules share a common framework but
>>> the text one has had work done on it and the spatial one hasn't. It would
>>> be good to find the common framework and redo the spatial query module to
>>> share the general mechanisms with the text query.
>>>
>>> 3/ Bruno was looking at JENA-632 (JSON from SPARQL) : Bruno - is there
>>> anything here to collaborate on?
>>>
>>> 4/ There was a discussion users@ about better formatting of JSON-LD.
>>> This is not an open ended pretty printed project (which is hard and no one
>>> is ever happy with the outcome!); it's to let a JSON-LD @context be passed
>>> through the writer code in the RIOT context (same word - completely
>>> different thing - it's a map of parameters) and then be passed to the 3rd
>>> part JSON-LD writer Jena uses.
>>>
>>> 5/ JENA-508 - there are some missing XQuery/Xpath functions list at the
>>> end of this JIRA. I think with those, jena would have all the relevant ones
>>> (that is, the ones on scalars and not specific to XML).
>>>
>>>          Andy
>>>
>>>
>>
>


Re: Contributing to the code

Posted by Alessandro Seganti <al...@gmail.com>.
Andy,
I started working on task JENA-508 namely adding these fn functions:

fn:normalize-space
fn:normalize-unicode
fn:format-number
fn:round-half-to-even
fn:adjust-dateTime-to-timezone
fn:adjust-date-to-timezone
fn:adjust-time-to-timezone
fn:format-dateTime
fn:format-date
fn:format-time


but I cannot change the status of the task. Is there something I need to do
in order to change the status ?

Regards,
Alessandro





2016-04-24 9:26 GMT+02:00 Alessandro Seganti <al...@gmail.com>:

> Andy,
> thank you for getting back to me! I will give a look to the list of things
> you wrote to me and try to get some insight on them. 1/ and 5/ seems the
> most feasible in the short term. 2/ and 3/ seem very interesting but I will
> need some more info to start working on it :) Anyway if I have any
> questions I will ask.
>
> Alessandro
>
> 2016-04-16 18:32 GMT+02:00 Andy Seaborne <an...@apache.org>:
>
>> On 11/04/16 18:50, Alessandro Seganti wrote:
>>
>>> Hi,
>>> I was looking around but I have not found any other task. If someone has
>>> in
>>> mind another task that I can do just let me know.
>>>
>>> Regards,
>>> Alessandro
>>>
>>
>> Hi there,
>>
>> The tasks could use some cleaning and categorising.  IMO many of the open
>> ended tasks over, say 2year, could be resolved "won't fix" and a note to
>> reopen only there is new input.
>>
>> Anyway, some suggestions:
>>
>>
>> 1/ JENA-647 : This is adding template queries to Fuseki.
>>
>> The idea is that server has a service where instead of a query, the
>> requests has a template name and values for variables.  A template lists
>> some variables that must be defined as part of its definition in an
>> assembler.
>>
>> Such a service means a published dataset can have just a fixed set of
>> template queries to access it.
>>
>> http://localhost/3030/ds/template?id=nameoftemplat&var_A=<http://example
>> >&var_B=123
>>
>> First step is to write a design.
>>
>> 2/ The Spatial query and text query modules share a common framework but
>> the text one has had work done on it and the spatial one hasn't. It would
>> be good to find the common framework and redo the spatial query module to
>> share the general mechanisms with the text query.
>>
>> 3/ Bruno was looking at JENA-632 (JSON from SPARQL) : Bruno - is there
>> anything here to collaborate on?
>>
>> 4/ There was a discussion users@ about better formatting of JSON-LD.
>> This is not an open ended pretty printed project (which is hard and no one
>> is ever happy with the outcome!); it's to let a JSON-LD @context be passed
>> through the writer code in the RIOT context (same word - completely
>> different thing - it's a map of parameters) and then be passed to the 3rd
>> part JSON-LD writer Jena uses.
>>
>> 5/ JENA-508 - there are some missing XQuery/Xpath functions list at the
>> end of this JIRA. I think with those, jena would have all the relevant ones
>> (that is, the ones on scalars and not specific to XML).
>>
>>         Andy
>>
>>
>

Re: Contributing to the code

Posted by Alessandro Seganti <al...@gmail.com>.
Andy,
thank you for getting back to me! I will give a look to the list of things
you wrote to me and try to get some insight on them. 1/ and 5/ seems the
most feasible in the short term. 2/ and 3/ seem very interesting but I will
need some more info to start working on it :) Anyway if I have any
questions I will ask.

Alessandro

2016-04-16 18:32 GMT+02:00 Andy Seaborne <an...@apache.org>:

> On 11/04/16 18:50, Alessandro Seganti wrote:
>
>> Hi,
>> I was looking around but I have not found any other task. If someone has
>> in
>> mind another task that I can do just let me know.
>>
>> Regards,
>> Alessandro
>>
>
> Hi there,
>
> The tasks could use some cleaning and categorising.  IMO many of the open
> ended tasks over, say 2year, could be resolved "won't fix" and a note to
> reopen only there is new input.
>
> Anyway, some suggestions:
>
>
> 1/ JENA-647 : This is adding template queries to Fuseki.
>
> The idea is that server has a service where instead of a query, the
> requests has a template name and values for variables.  A template lists
> some variables that must be defined as part of its definition in an
> assembler.
>
> Such a service means a published dataset can have just a fixed set of
> template queries to access it.
>
> http://localhost/3030/ds/template?id=nameoftemplat&var_A=<http://example
> >&var_B=123
>
> First step is to write a design.
>
> 2/ The Spatial query and text query modules share a common framework but
> the text one has had work done on it and the spatial one hasn't. It would
> be good to find the common framework and redo the spatial query module to
> share the general mechanisms with the text query.
>
> 3/ Bruno was looking at JENA-632 (JSON from SPARQL) : Bruno - is there
> anything here to collaborate on?
>
> 4/ There was a discussion users@ about better formatting of JSON-LD. This
> is not an open ended pretty printed project (which is hard and no one is
> ever happy with the outcome!); it's to let a JSON-LD @context be passed
> through the writer code in the RIOT context (same word - completely
> different thing - it's a map of parameters) and then be passed to the 3rd
> part JSON-LD writer Jena uses.
>
> 5/ JENA-508 - there are some missing XQuery/Xpath functions list at the
> end of this JIRA. I think with those, jena would have all the relevant ones
> (that is, the ones on scalars and not specific to XML).
>
>         Andy
>
>

Re: Contributing to the code

Posted by Andy Seaborne <an...@apache.org>.
On 11/04/16 18:50, Alessandro Seganti wrote:
> Hi,
> I was looking around but I have not found any other task. If someone has in
> mind another task that I can do just let me know.
>
> Regards,
> Alessandro

Hi there,

The tasks could use some cleaning and categorising.  IMO many of the 
open ended tasks over, say 2year, could be resolved "won't fix" and a 
note to reopen only there is new input.

Anyway, some suggestions:


1/ JENA-647 : This is adding template queries to Fuseki.

The idea is that server has a service where instead of a query, the 
requests has a template name and values for variables.  A template lists 
some variables that must be defined as part of its definition in an 
assembler.

Such a service means a published dataset can have just a fixed set of 
template queries to access it.

http://localhost/3030/ds/template?id=nameoftemplat&var_A=<http://example>&var_B=123

First step is to write a design.

2/ The Spatial query and text query modules share a common framework but 
the text one has had work done on it and the spatial one hasn't. It 
would be good to find the common framework and redo the spatial query 
module to share the general mechanisms with the text query.

3/ Bruno was looking at JENA-632 (JSON from SPARQL) : Bruno - is there 
anything here to collaborate on?

4/ There was a discussion users@ about better formatting of JSON-LD. 
This is not an open ended pretty printed project (which is hard and no 
one is ever happy with the outcome!); it's to let a JSON-LD @context be 
passed through the writer code in the RIOT context (same word - 
completely different thing - it's a map of parameters) and then be 
passed to the 3rd part JSON-LD writer Jena uses.

5/ JENA-508 - there are some missing XQuery/Xpath functions list at the 
end of this JIRA. I think with those, jena would have all the relevant 
ones (that is, the ones on scalars and not specific to XML).

	Andy


Re: Contributing to the code

Posted by Alessandro Seganti <al...@gmail.com>.
Hi,
I was looking around but I have not found any other task. If someone has in
mind another task that I can do just let me know.

Regards,
Alessandro

2016-04-01 8:21 GMT+02:00 Alessandro Seganti <al...@gmail.com>:

> Hi Andy,
> I finally managed to make the pull request (
> https://github.com/apache/jena/pull/132)!
> Let me know what you think.
>
>
>
> 2016-03-18 17:46 GMT+01:00 Andy Seaborne <an...@apache.org>:
>
>> Hi Alessandro,
>>
>> On 18/03/16 06:39, Alessandro Seganti wrote:
>>
>>> Hi,
>>> I forgot another thing: is there a way to get the locale that should be
>>> used for string conversion inside the
>>> jena-arq/.../sparql/expr/nodevalue/XSDFuncOp class? I need this to
>>> convert
>>> numbers to strings (using or not the dot).
>>>
>>
>> In XSD, any number to string should be happening locale-independent, ie
>> Locale.ROOT so the issue has never come up before.  You need to get the
>> Locale in force.
>>
>>
>> 2016-03-17 21:28 GMT+01:00 Alessandro Seganti <
>>> alessandro.seganti@gmail.com>
>>>
>>>> Hi Andy,
>>>> it took me some time to understand how the code is organized but I think
>>>> that I have completed the JENA-967 task. I have still some doubts but I
>>>> need to show you the code to explain my problem. I wanted to make a pull
>>>> request on github but I was denied access. Do I need to do something
>>>> lese
>>>> before having access to the repository? My github account is under
>>>> cicerone54@hotmail.com.
>>>>
>>>
>> What should work is to fork http://github.com/apache/jena in github,
>> work on the clone ("git:" URL) cloned to the local machine, then do a
>> github UI "pull request".  Is that what you tried?  What access denied did
>> you get?
>>
>>         Andy
>>
>>
>