You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/05 10:13:51 UTC
[GitHub] [superset] geido opened a new pull request, #19956: feat: Applitools Cypress workflow
geido opened a new pull request, #19956:
URL: https://github.com/apache/superset/pull/19956
### SUMMARY
Please ignore it for now
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
geido merged PR #19956:
URL: https://github.com/apache/superset/pull/19956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #19956:
URL: https://github.com/apache/superset/pull/19956#discussion_r866096285
##########
superset-frontend/cypress-base/cypress/integration/dashboard_list/dashboardlist.applitools.test.ts:
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { DASHBOARD_LIST } from './dashboard_list.helper';
+
+describe('dashboard list view', () => {
+ beforeEach(() => {
+ cy.login();
+ cy.visit(DASHBOARD_LIST);
+ });
+
+ afterEach(() => {
+ cy.eyesClose();
+ });
+
+ it('should load the Dashboards list', () => {
+ cy.get('[aria-label="list-view"]').click();
+ cy.eyesOpen({
+ testName: 'Dashboards list-view',
+ });
+ cy.eyesCheckWindow('Dashboards loaded');
+ });
+
+ it('should load the Dashboards card list', () => {
+ cy.get('[aria-label="card-view"]').click();
+ cy.eyesOpen({
+ testName: 'Dashboards card-view',
+ });
+ cy.eyesCheckWindow('Dashboards loaded');
Review Comment:
what's the significance of the name that you pass to `eyesCheckWindow` and do these names have to be unique? Looking at how these two tests here have the same string passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19956:
URL: https://github.com/apache/superset/pull/19956#issuecomment-1118743663
> Not familiar with applitools for cypress but I have general concern how it would work with randomized css-xxx items in DOM which can be changed between builds. Would this DOM verification be stable and reliable?
It doesn't even look at the dom... it literally takes screenshots of the UI and compares them to prior runs. in theory, you could change ALL SORTS of styling code, but if it looks the same, the tests will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19956:
URL: https://github.com/apache/superset/pull/19956#issuecomment-1118416949
# [Codecov](https://codecov.io/gh/apache/superset/pull/19956?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19956](https://codecov.io/gh/apache/superset/pull/19956?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be5ee02) into [master](https://codecov.io/gh/apache/superset/commit/902ac053722ada89f817156a0af38ec03f27376c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (902ac05) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head be5ee02 differs from pull request most recent head fabd5b6. Consider uploading reports for the commit fabd5b6 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19956 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 1712 1712
Lines 63957 63957
Branches 6720 6720
=======================================
Hits 42390 42390
Misses 19859 19859
Partials 1708 1708
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.26% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19956?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19956?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [902ac05...fabd5b6](https://codecov.io/gh/apache/superset/pull/19956?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on PR #19956:
URL: https://github.com/apache/superset/pull/19956#issuecomment-1118406791
Not familiar with applitools for cypress but I have general concern how it would work with randomized css-xxx items in DOM which can be changed between builds. Would this DOM verification be stable and reliable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19956: feat: Applitools Cypress workflow
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19956:
URL: https://github.com/apache/superset/pull/19956#discussion_r866112224
##########
superset-frontend/cypress-base/cypress/integration/dashboard_list/dashboardlist.applitools.test.ts:
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { DASHBOARD_LIST } from './dashboard_list.helper';
+
+describe('dashboard list view', () => {
+ beforeEach(() => {
+ cy.login();
+ cy.visit(DASHBOARD_LIST);
+ });
+
+ afterEach(() => {
+ cy.eyesClose();
+ });
+
+ it('should load the Dashboards list', () => {
+ cy.get('[aria-label="list-view"]').click();
+ cy.eyesOpen({
+ testName: 'Dashboards list-view',
+ });
+ cy.eyesCheckWindow('Dashboards loaded');
+ });
+
+ it('should load the Dashboards card list', () => {
+ cy.get('[aria-label="card-view"]').click();
+ cy.eyesOpen({
+ testName: 'Dashboards card-view',
+ });
+ cy.eyesCheckWindow('Dashboards loaded');
Review Comment:
Apparently these are enclosed within each test... they don't need to be unique it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org