You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/04/25 08:14:26 UTC

Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-6504
    https://issues.apache.org/jira/browse/CLOUDSTACK-6504


Repository: cloudstack-git


Description
-------

 removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed.


Diffs
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 

Diff: https://reviews.apache.org/r/20701/diff/


Testing
-------

tested by creating the fresh setup after the removal of warnings.


Thanks,

Anshul Gangwar


Re: Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/#review41451
-----------------------------------------------------------


Commit 6511b96088af75b7e37a5f8b0cce609b006021fb in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6511b96 ]

CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code


- ASF Subversion and Git Services


On April 25, 2014, 6:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20701/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 6:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6504
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6504
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 
> 
> Diff: https://reviews.apache.org/r/20701/diff/
> 
> 
> Testing
> -------
> 
> tested by creating the fresh setup after the removal of warnings.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/#review48855
-----------------------------------------------------------


Commit 8fb89cdc8e2dff60d49fecd3e51a9bf997061035 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8fb89cd ]

CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code

(cherry picked from commit 66f8e0e1b5c81cbfde926c0c65c4d5969767cab9)

Conflicts:
	plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
	plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs


- ASF Subversion and Git Services


On April 25, 2014, 6:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20701/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 6:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6504
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6504
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 
> 
> Diff: https://reviews.apache.org/r/20701/diff/
> 
> 
> Testing
> -------
> 
> tested by creating the fresh setup after the removal of warnings.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/#review41448
-----------------------------------------------------------


Commit 66f8e0e1b5c81cbfde926c0c65c4d5969767cab9 in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=66f8e0e ]

CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code


- ASF Subversion and Git Services


On April 25, 2014, 6:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20701/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 6:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6504
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6504
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 
> 
> Diff: https://reviews.apache.org/r/20701/diff/
> 
> 
> Testing
> -------
> 
> tested by creating the fresh setup after the removal of warnings.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/#review41456
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On April 25, 2014, 6:14 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20701/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 6:14 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6504
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6504
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  removed the warnings coming in building hyper-v agent code. One warning related to System.Net.Http dependency is still there. All other warnings have been removed.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs c222102 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 0f084db 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs d0d3d83 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 4795073 
> 
> Diff: https://reviews.apache.org/r/20701/diff/
> 
> 
> Testing
> -------
> 
> tested by creating the fresh setup after the removal of warnings.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>