You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/17 17:24:45 UTC

[GitHub] [hbase] ndimiduk commented on a change in pull request #3015: HBASE-25623 : Shell commands should accept 'hbase:meta' as an alias for the encoded region name

ndimiduk commented on a change in pull request #3015:
URL: https://github.com/apache/hbase/pull/3015#discussion_r596234014



##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -591,6 +591,10 @@ def unassign(region_name, force = nil)
     #----------------------------------------------------------------------------------------------
     # Move a region
     def move(encoded_region_name, server = nil)
+      if encoded_region_name == 'hbase:meta'

Review comment:
       I think it would be much better if the Admin API supported this feature directly. That way, it works the same way, everywhere. Is there a strong reason to implement it only in the shell?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org