You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "Sakshi-75 (via GitHub)" <gi...@apache.org> on 2023/10/21 16:37:27 UTC

[PR] add unit tests for SubqueryExpressionSegmentBinder.java [shardingsphere]

Sakshi-75 opened a new pull request, #28832:
URL: https://github.com/apache/shardingsphere/pull/28832

   Fixes #28506 
   
   Changes proposed in this pull request:
     -
   Added unit tests for SubqueryExpressionSegmentBinder.java
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] add unit tests for SubqueryExpressionSegmentBinder.java [shardingsphere]

Posted by "Sakshi-75 (via GitHub)" <gi...@apache.org>.

Sakshi-75 commented on PR #28832:
URL: https://github.com/apache/shardingsphere/pull/28832#issuecomment-1783481450

   Hi @zhaojinchao95 , please review and let me know if any changes are required in this PR. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] add unit tests for SubqueryExpressionSegmentBinder.java [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.

terrymanu merged PR #28832:
URL: https://github.com/apache/shardingsphere/pull/28832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org