You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "hongbin ma (JIRA)" <ji...@apache.org> on 2017/08/22 06:13:00 UTC

[jira] [Created] (KYLIN-2801) Make default precision and scale in DataType (for hive) configurable

hongbin ma created KYLIN-2801:
---------------------------------

             Summary: Make default precision and scale in DataType (for hive) configurable
                 Key: KYLIN-2801
                 URL: https://issues.apache.org/jira/browse/KYLIN-2801
             Project: Kylin
          Issue Type: Improvement
            Reporter: hongbin ma


currently these values are hard coded:

{code:java}
  // FIXME 256 for unknown string precision
        if ((name.equals("char") || name.equals("varchar")) && precision == -1) {
            precision = 256; // to save memory at frontend, e.g. tableau will
                             // allocate memory according to this
            if (name.equals("char")) {
                precision -= 1; //at most 255 according to https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-CharcharChar
            }
        }

        // FIXME (19,4) for unknown decimal precision
        if ((name.equals("decimal") || name.equals("numeric")) && precision == -1) {
            precision = 19;
            scale = 4;
        }

{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)