You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/23 11:03:03 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #13217: [MINOR]: [Docs] Update phrasing of intro sentence in the new contributors guide
thisisnic opened a new pull request, #13217:
URL: https://github.com/apache/arrow/pull/13217
A tiny phrasing suggestion - I think this sounds stronger this way; it's not just **intended** to be a resource for new contributors, is **is** a resource for new contributors.
CC @AlenkaF - let me know what you think, happy to close this PR unmerged if the old phrasing is preferred!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #13217: MINOR: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #13217: MINOR: [Docs] Update phrasing of intro sentence in the new contributors guide
URL: https://github.com/apache/arrow/pull/13217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13217: MINOR: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13217:
URL: https://github.com/apache/arrow/pull/13217#issuecomment-1135394722
Benchmark runs are scheduled for baseline = 119ead4346d8749f793476a182f1cc55c7d6401b and contender = 43a604de6b44394f99900a3ae9e869d3c11670eb. 43a604de6b44394f99900a3ae9e869d3c11670eb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/41e20d98fd67495b93815e510bce5bac...a0d6ade37ca24700aa6a94fa7e877861/)
[Failed :arrow_down:0.47% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d3379326e444468dbfc51494c6974d5b...a4ac04d8c6124a409192eadedc067e78/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/312eb198fad44b70bc00b5962b4090e7...dcc25a3f7e3d4967849a34852f9771c6/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/49a8645fd4b7439ab9dabe9ed65ff00c...a5d67b43dd0c4042adc53da4faec8ca8/)
Buildkite builds:
[Finished] [`43a604de` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/812)
[Failed] [`43a604de` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/809)
[Failed] [`43a604de` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/799)
[Finished] [`43a604de` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/815)
[Finished] [`119ead43` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/811)
[Failed] [`119ead43` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/808)
[Failed] [`119ead43` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/798)
[Finished] [`119ead43` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/814)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13217: [MINOR]: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13217:
URL: https://github.com/apache/arrow/pull/13217#issuecomment-1134560427
The format should be "MINOR: [Docs] ..." not "[MINOR]: [Docs] ..." I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13217: [MINOR]: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13217:
URL: https://github.com/apache/arrow/pull/13217#issuecomment-1134528720
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #13217: [MINOR]: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
thisisnic commented on PR #13217:
URL: https://github.com/apache/arrow/pull/13217#issuecomment-1134531946
Hmm, looks like this is getting a false positive for not being a minor PR as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #13217: [MINOR]: [Docs] Update phrasing of intro sentence in the new contributors guide
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on PR #13217:
URL: https://github.com/apache/arrow/pull/13217#issuecomment-1134566952
LGTM! +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org