You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/07/11 17:27:21 UTC
[GitHub] zeppelin pull request #1165: [HOTFIX] build fail after merge #1151
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1165
[HOTFIX] build fail after merge #1151
### What is this PR for?
#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.
```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) @ zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO] 21 | angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO] 22 | var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO] 23 | content= BOM + content;
[INFO] ---------------------^
[INFO] 24 | frameSaveAs.document.open('text/json', 'replace');
[INFO] 25 | frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```
### What type of PR is it?
Hot Fix
### Todos
* [x] - Fix problem
### What is the Jira issue?
ZEPPELIN-1138, ZEPPELIN-235
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin fix_js
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1165
----
commit 3819ffb12c00d67e640263d0727cce06eca54f67
Author: Lee moon soo <mo...@apache.org>
Date: 2016-07-11T17:24:29Z
add space
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1165: [HOTFIX] build fail after merge #1151
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1165
Merge it in master (and branch-0.6 while #1151 is merged in branch-0.6) as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1165: [HOTFIX] build fail after merge #1151
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---