You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/26 07:18:14 UTC

[GitHub] [incubator-yunikorn-core] manirajv06 commented on pull request #266: YUNIKORN-637: Core side changes of YUNIKORN-490

manirajv06 commented on pull request #266:
URL: https://github.com/apache/incubator-yunikorn-core/pull/266#issuecomment-826574573


   > I don't think we need to import api with an alias (apiCommon). There is no other api package.
   > That will also limit the changes needed.
   > 
   > I also think that the go.mod file change is missing from the commit. It should point to:
   > `github.com/apache/incubator-yunikorn-scheduler-interface v0.0.0-20210420020902-c2149f9635f6`
   > Please notice the special semver v0.0.0 we should have used that for a long time...
   
   Taken care.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org