[GitHub] [geode-native] igodwin opened pull request #533: GEODE-7235: Add backwards compatibility for Clang

["igodwin (GitHub)" <gi...@apache.org>]

-  One of the new flags added for Clang 11 support, -Wno-defaulted-function-deleted, was not available to earlier versions of Clang

Co-authored-by: Michael Oleske <mo...@pivotal.io>

[ Full content available at: https://github.com/apache/geode-native/pull/533 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #533: GEODE-7235: Add backwards compatibility for Clang

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Below, we set ignored compiler warnings based on the following test:
```
if(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
```
if that check works, we should be able to use the same one here, and change the variable name to something like CONDITIONALLY_DISABLED_CLANG_WARNINGS, a lot more generic than "AppleClang" and MAC.

[ Full content available at: https://github.com/apache/geode-native/pull/533 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #533: GEODE-7235: Add backwards compatibility for Clang

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Come to think of it, we could/should check and disable these warnings separately, for correctness' sake.

[ Full content available at: https://github.com/apache/geode-native/pull/533 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org