You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/12 08:45:13 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4636: Count the coverage in E2E tests

kezhenxu94 commented on a change in pull request #4636: Count the coverage in E2E tests
URL: https://github.com/apache/skywalking/pull/4636#discussion_r407167338
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/entity/ProfileTaskCreationResult.java
 ##########
 @@ -16,7 +16,7 @@
  *
  */
 
-package org.apache.skywalking.oap.server.core.profile.entity;
+package org.apache.skywalking.oap.server.core.query.entity;
 
 Review comment:
   > I think this is mischange?
   
   The GraphQL resolver will generate some classes for the query entities, which breaks the Jacoco agent, we have to exclude these classes in Jacoco, though I can have another rules to exclude this particular class (`ProfileTaskCreationResult`), but I think it belongs package `org.apache.skywalking.oap.server.core.query.entity`, as other similar query entities

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services