Re: [PR] DRILL-4934 ServiceEngine does not use property useIP for DrillbitStartup (drill)

["jnturton (via GitHub)" <gi...@apache.org>]

jnturton commented on PR #617:
URL: https://github.com/apache/drill/pull/617#issuecomment-1520128915

   @joeswingle the removed code that obtained an IP address fr the Drillbit when this flag was set was
   ```
   useIP ? InetAddress.getLocalHost().getHostAddress() : InetAddress.getLocalHost().getCanonicalHostName();
   ```
   That, from what I can tell, is generally going to return the IP address of the local loopback interface which would not have any effect on embedded Drill but would be useless for distributed Drill which is the only place it would be of interest. Now that we have `DRILL_HOST_NAME` I think we can get by without a feature like this but let me know if you'd like me to reopen here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org