[GitHub] [calcite] julianhyde commented on a change in pull request #2333: [CALCITE-4347] Add type inference for SqlSubstringFunction (Louis Kuang)

[GitBox <gi...@apache.org>]

julianhyde commented on a change in pull request #2333:
URL: https://github.com/apache/calcite/pull/2333#discussion_r563220868



##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -7810,9 +7810,6 @@ public void _testGroupExpressionEquivalenceParams() {
     sql("select * from emp where deptno = ?").ok();
     sql("select * from emp where deptno = ? and sal < 100000").ok();
     sql("select case when deptno = ? then 1 else 2 end from emp").ok();
-    // It is not possible to infer type of ?, because SUBSTRING is overloaded
-    sql("select deptno from emp group by substring(ename from ^?^ for ?)")
-        .fails("Illegal use of dynamic parameter");

Review comment:
       It's a bit strange to comment on your own PR. Let's talk in the JIRA case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org