You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by knutsel <gi...@git.apache.org> on 2017/01/21 00:08:40 UTC
[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...
GitHub user knutsel opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/208
Fix TC-110 - parameterize ip_allow coalescing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knutsel/incubator-trafficcontrol TC-110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit a7035f863b42f2815d82c01eea1df620b02d4853
Author: Jan van Doorn <jv...@apache.org>
Date: 2017-01-21T00:07:46Z
Fix TC-110 - parameterize ip_allow coalescing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/208#discussion_r97334319
--- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
@@ -475,9 +475,14 @@ sub ip_allow_data {
$ipallow->[$i]->{action} = 'ip_allow';
$ipallow->[$i]->{method} = "ALL";
$i++;
+
+ # default for coalesce_ipv4 = 24, 5 and for ipv6 48, 5; override with the parameters in the server profile.
--- End diff --
maybe just get rid of the comment? it doesn't look like it's accurate with the code below
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...
Posted by knutsel <gi...@git.apache.org>.
Github user knutsel commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/208#discussion_r97372213
--- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
@@ -475,9 +475,14 @@ sub ip_allow_data {
$ipallow->[$i]->{action} = 'ip_allow';
$ipallow->[$i]->{method} = "ALL";
$i++;
+
+ # default for coalesce_ipv4 = 24, 5 and for ipv6 48, 5; override with the parameters in the server profile.
--- End diff --
fixed code... <blush>; thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/208#discussion_r97332624
--- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
@@ -533,9 +550,8 @@ sub ip_allow_data {
}
# compact, coalesce and compact combined list again
- # if more than 5 servers are in a /24, list that /24 - TODO JvD: parameterize
my @compacted_list = NetAddr::IP::Compact(@allowed_netaddrips);
- my $coalesced_list = NetAddr::IP::Coalesce( 24, 5, @allowed_netaddrips );
+ my $coalesced_list = NetAddr::IP::Coalesce( $coalesce_masklen_v4 , $coalesce_masklen_v4, @allowed_netaddrips );
--- End diff --
I think you meant
my $coalesced_list = NetAddr::IP::Coalesce( $coalesce_masklen_v4 , $coalesce_number_v4, @allowed_netaddrips );
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---