You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/14 16:21:20 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #1173: Fix tests for Rust 1.58 release
alamb opened a new pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173
# Rationale for this change
Test output changed with rust 1.58
# What changes are included in this PR?
1. Add a reference to https://github.com/rust-lang/rust-clippy/issues/8045 explaining why that lint is disabled
2. Update test output due to change in rust: https://github.com/rust-lang/rust/commit/8731d4dfb479914a91f650f4f124528e332e8128#diff-363ad34c0858be71721f73b0880238813baf8f8b36ebbb494baa6b29103dd8d5
Kudos to @jhorstmann for researching both of those
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#discussion_r784988514
##########
File path: parquet/src/record/api.rs
##########
@@ -1081,9 +1081,9 @@ mod tests {
fn test_convert_float_to_string() {
assert_eq!(format!("{}", Field::Float(1.0)), "1.0");
assert_eq!(format!("{}", Field::Float(9.63)), "9.63");
- assert_eq!(format!("{}", Field::Float(1e-15)), "0.000000000000001");
+ assert_eq!(format!("{}", Field::Float(1e-15)), "1e-15");
Review comment:
I don't really know if this is correct output or not
The code that handles formatting this is here: https://github.com/apache/arrow-rs/blob/master/parquet/src/record/api.rs#L716-L729
Which came in from @sunchao in the original donation 3 years ago in https://github.com/apache/arrow-rs/commit/6d12823d6665f86eb2e410af7577fe90a83ad46b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#discussion_r784990770
##########
File path: parquet/src/record/api.rs
##########
@@ -1081,9 +1081,9 @@ mod tests {
fn test_convert_float_to_string() {
assert_eq!(format!("{}", Field::Float(1.0)), "1.0");
assert_eq!(format!("{}", Field::Float(9.63)), "9.63");
- assert_eq!(format!("{}", Field::Float(1e-15)), "0.000000000000001");
+ assert_eq!(format!("{}", Field::Float(1e-15)), "1e-15");
Review comment:
I have the same question as @jhorstmann on #1169
> I don't know why we assert that exact formatting though. Also seems intentional because there is a range check in fmt::Display for parquet::record::api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#issuecomment-1013290588
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1173](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f033b6) into [master](https://codecov.io/gh/apache/arrow-rs/commit/231cf788879f12b3cfbc6da776e2360117567d17?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (231cf78) will **increase** coverage by `0.04%`.
> The diff coverage is `77.27%`.
> :exclamation: Current head 0f033b6 differs from pull request most recent head 466394a. Consider uploading reports for the commit 466394a to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 82.59% 82.63% +0.04%
==========================================
Files 173 173
Lines 50919 50858 -61
==========================================
- Hits 42055 42026 -29
+ Misses 8864 8832 -32
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/buffer/immutable.rs](https://codecov.io/gh/apache/arrow-rs/pull/1173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9pbW11dGFibGUucnM=) | `98.92% <ø> (ø)` | |
| [parquet/src/schema/printer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvc2NoZW1hL3ByaW50ZXIucnM=) | `72.47% <50.00%> (ø)` | |
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/1173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `90.86% <73.33%> (+5.29%)` | :arrow_up: |
| [arrow/src/util/test\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/1173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvdGVzdF91dGlsLnJz) | `92.04% <100.00%> (ø)` | |
| [parquet/src/record/api.rs](https://codecov.io/gh/apache/arrow-rs/pull/1173/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvcmVjb3JkL2FwaS5ycw==) | `91.61% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5fb0534...466394a](https://codecov.io/gh/apache/arrow-rs/pull/1173?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a change in pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
tustvold commented on a change in pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#discussion_r785208970
##########
File path: parquet/src/record/api.rs
##########
@@ -1081,9 +1081,9 @@ mod tests {
fn test_convert_float_to_string() {
assert_eq!(format!("{}", Field::Float(1.0)), "1.0");
assert_eq!(format!("{}", Field::Float(9.63)), "9.63");
- assert_eq!(format!("{}", Field::Float(1e-15)), "0.000000000000001");
+ assert_eq!(format!("{}", Field::Float(1e-15)), "1e-15");
Review comment:
Only just seeing this, but I created #1178 which preserves the old behaviour as far as I could guess at it. Happy for you to go with this PR though if you would prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1173: Update test output for Rust 1.58 release
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#discussion_r785299353
##########
File path: parquet/src/record/api.rs
##########
@@ -1081,9 +1081,9 @@ mod tests {
fn test_convert_float_to_string() {
assert_eq!(format!("{}", Field::Float(1.0)), "1.0");
assert_eq!(format!("{}", Field::Float(9.63)), "9.63");
- assert_eq!(format!("{}", Field::Float(1e-15)), "0.000000000000001");
+ assert_eq!(format!("{}", Field::Float(1e-15)), "1e-15");
Review comment:
#1178 looks better to me .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org