[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8658: fix: handle duplicate groupby keys

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #8658: fix: handle duplicate groupby keys
URL: https://github.com/apache/incubator-superset/pull/8658#discussion_r354082400
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -731,6 +731,9 @@ def get_sqla_query(  # sqla
         groupby_exprs_sans_timestamp: OrderedDict = OrderedDict()
 
         if groupby:
+            # dedup columns while preserving order
+            groupby = list(dict.fromkeys(groupby))
 
 Review comment:
   oh it's a way do dedup while preserving ordering in py3 (now that dict preserve order)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org